-
Notifications
You must be signed in to change notification settings - Fork 34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Frontend] Add support for logical or, and and not in autograph #325
Conversation
Co-authored-by: David Ittah <dime10@users.noreply.github.com>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #325 +/- ##
=======================================
Coverage 99.62% 99.62%
=======================================
Files 42 42
Lines 7438 7454 +16
Branches 434 439 +5
=======================================
+ Hits 7410 7426 +16
Misses 14 14
Partials 14 14
☔ View full report in Codecov by Sentry. |
Hi @josh146. I expect this logic ops implementation to have corner-cases, so I 'd like to know what do we want to support in the first place here. Do we have any particular use-cases in mind, e.g. among the tutorial algorithms which I could check? |
…m of the pipeline
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good 👍
Co-authored-by: David Ittah <dime10@users.noreply.github.com>
Support Python and-, or- and not- operators in Autograph-converted programs.
[sc-41303]
Test cases mentioned: