-
Notifications
You must be signed in to change notification settings - Fork 34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Frontend] Fix AutoGraph not converting functions wrapped by 'adjoint', 'grad', etc. #336
Conversation
Also reorgonaize & format recent entries.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am not an expert in autograph yet. The tests look good. I have noticed that some tests use the variable backend while others are hard coded to be lightning. I think it is best if we always use backend.
I deliberately didn't use it here because I'm only testing frontend functionality. I just had to use a QNode to use adjoint, otherwise I wouldn't have. I agree that most tests should use backend, unless they are not testing execution functionality. |
Co-authored-by: erick-xanadu <110487834+erick-xanadu@users.noreply.github.com>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #336 +/- ##
=======================================
Coverage 99.56% 99.56%
=======================================
Files 42 42
Lines 7404 7410 +6
Branches 432 433 +1
=======================================
+ Hits 7372 7378 +6
Misses 16 16
Partials 16 16
☔ View full report in Codecov by Sentry. |
The following example would fail before the fix:
[sc-48511]