Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[CI] Binaries are available for macOS aarch64 and x86_64 #347

Merged
merged 20 commits into from
Nov 7, 2023
Merged

[CI] Binaries are available for macOS aarch64 and x86_64 #347

merged 20 commits into from
Nov 7, 2023

Conversation

maliasadi
Copy link
Member

@maliasadi maliasadi commented Nov 1, 2023 •
edited
Loading

  • Add wheels recipes for macOS aarch64 and x86_64
  • Update Make commands to support building from src on both Linux and macOS
  • Fix a few minor issues in the build system and typos

[sc-46388]

@dime10 dime10 added this to the Catalyst v0.3.2 milestone Nov 3, 2023
@maliasadi maliasadi changed the title [CI] Building wheels for MacOS x86_64 [CI] Binaries are available for macOS aarch64 and x86_64 Nov 6, 2023
@maliasadi maliasadi marked this pull request as ready for review November 6, 2023 03:28
@maliasadi maliasadi requested a review from dime10 November 6, 2023 22:07
dime10
dime10 reviewed Nov 6, 2023
View reviewed changes
Copy link
Contributor

@dime10 dime10 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work @maliasadi 🥳

I see the two actions are practically identical, should we not make use of the matrix feature?

.github/workflows/build-wheel-macos-arm64.yaml Outdated Show resolved Hide resolved
.github/workflows/build-wheel-macos-arm64.yaml Outdated Show resolved Hide resolved
mlir/Makefile Show resolved Hide resolved
runtime/Makefile Outdated Show resolved Hide resolved
runtime/tests/CMakeLists.txt Show resolved Hide resolved
runtime/tests/Test_LightningCoreQIS.cpp Outdated Show resolved Hide resolved
.github/workflows/build-wheel-macos-x86_64.yaml Outdated Show resolved Hide resolved
.github/workflows/build-wheel-macos-x86_64.yaml Show resolved Hide resolved
dime10
dime10 reviewed Nov 7, 2023
View reviewed changes
Makefile Show resolved Hide resolved
@maliasadi maliasadi requested a review from dime10 November 7, 2023 18:38
dime10
dime10 approved these changes Nov 7, 2023
View reviewed changes
Copy link
Contributor

@dime10 dime10 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work 🦝

@maliasadi @dime10
Apply suggestions from code review
64880cf 
Co-authored-by: David Ittah <dime10@users.noreply.github.com>
@maliasadi maliasadi merged commit a848332 into main Nov 7, 2023
19 checks passed
@maliasadi maliasadi deleted the maa/ci/wheel-macos-x86 branch November 7, 2023 19:30
@maliasadi maliasadi mentioned this pull request Nov 7, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dime10 dime10 dime10 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
Catalyst v0.3.2
Development

Successfully merging this pull request may close these issues.
2 participants
@maliasadi @dime10