Disable LightningKokkos OMP backend on macOS (x86_64) #478
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
erick-xanadu
approved these changes
Jan 26, 2024
|
Hello. You may have forgotten to update the changelog!
|
Merged
josh146
pushed a commit
that referenced
this pull request
Jan 29, 2024
We temporarily disable the OMP support for `LightningKokkos` only on macOS (x86_64) due to memory issues in the computation of Lightning's adjoint-jacobian in the presence of multiple OMP threads. This issue could be reproduced when building multiple Lightning simulators with `Kokkos_ENABLE_OPENMP=ON`. [sc-55321]
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We temporarily disable the OMP support for
LightningKokkosonly on macOS (x86_64) due to memory issues in the computation of Lightning's adjoint-jacobian in the presence of multiple OMP threads. This issue could be reproduced when building multiple Lightning simulators withKokkos_ENABLE_OPENMP=ON.[sc-55321]