Implementation of post-selection for mid-circuit measurements #491

rauletorresc · 2024-02-02T01:14:00Z

Context: At the python level the postselect argument is optional and defaults to None. When given, it can only be 1 or 0. At the Quantum dialect level postselect is also optional, but when lowered to the LLVM dialect, the call to the measure function expect a mandatory postselect argument that can contain one of the following values:

-1, meaning postselect was not used
0, for postselect = 0
1, for postselect = 1

Related GitHub Issues: #448

TODO:

Complete the frontend implementation and connect it with the MLIR part.
Improve test at ConversionTests.mlir
Implement the post-selection logic at the runtime side.
... also in Lightning.Kokkos
Add test cases.

[sc-46409]

maliasadi

Nice work @rauletorresc! 🎸

frontend/catalyst/pennylane_extensions.py

runtime/lib/backend/lightning/lightning_dynamic/LightningSimulator.cpp

mlir/include/Quantum/IR/QuantumOps.td

mlir/test/Quantum/ConversionTest.mlir

rmoyard

Nice job! Some suggestions and could you add a end to end integration test?

frontend/catalyst/pennylane_extensions.py

rmoyard

Nice job, some comments left. I think there are still some issues in the runtime to be solved, let me know if you need some help

mlir/include/Quantum/IR/QuantumOps.td

runtime/lib/backend/lightning/lightning_dynamic/LightningSimulator.cpp

rauletorresc · 2024-02-05T21:26:44Z

Still pending: Implement the post-selection logic at the runtime side.

rauletorresc · 2024-02-06T20:40:13Z

My only concern here is: all the shots are set up at the postselect value, e,g.: applying a Hadamard and having postselect=0, shots=10, we get the 10 shots as: [0,0,0,0,0,0,0,0,0,0]. Is that the intended behavior? I was hoiping to see [0,0,0,0,0]

mlir/test/Quantum/ConversionTest.mlir

maliasadi

Great work! 💯

frontend/catalyst/jax_primitives.py

frontend/test/pytest/test_mid_circuit_measurement.py

mlir/lib/Quantum/Transforms/ConversionPatterns.cpp

runtime/lib/backend/lightning/lightning_dynamic/LightningSimulator.cpp

runtime/tests/Test_LightningCoreQIS.cpp

mlir/test/Quantum/AdjointTest.mlir

mlir/include/Quantum/IR/QuantumOps.td

dime10

Looks great 💯

mlir/include/Quantum/IR/QuantumOps.td

runtime/include/QuantumDevice.hpp

codecov-commenter · 2024-02-09T00:58:03Z

Codecov Report

Attention: 2 lines in your changes are missing coverage. Please review.

Comparison is base (caf24e7) 99.57% compared to head (648f03e) 99.54%.

Files	Patch %	Lines
frontend/catalyst/pennylane_extensions.py	75.00%	1 Missing and 1 partial ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main     #491      +/-   ##
==========================================
- Coverage   99.57%   99.54%   -0.03%     
==========================================
  Files          43       43              
  Lines        7740     7775      +35     
  Branches      533      536       +3     
==========================================
+ Hits         7707     7740      +33     
- Misses         17       18       +1     
- Partials       16       17       +1

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

maliasadi

🚀

doc/changelog.md

frontend/test/pytest/test_mid_circuit_measurement.py

runtime/include/QuantumDevice.hpp

runtime/lib/backend/lightning/lightning_dynamic/LightningSimulator.hpp

runtime/tests/Test_LightningMeasures.cpp

rmoyard

Thanks for the PR it looks great!

doc/changelog.md

frontend/catalyst/pennylane_extensions.py

maliasadi

Thanks @rauletorresc! 💯

runtime/tests/Test_LightningMeasures.cpp

rauletorresc linked an issue Feb 2, 2024 that may be closed by this pull request

Implement post-selection for mid-circuit measurements #448

Closed

rauletorresc requested review from dime10 and maliasadi February 2, 2024 01:14

rauletorresc self-assigned this Feb 2, 2024

rauletorresc requested review from erick-xanadu, rmoyard and sergei-mironov February 2, 2024 01:14

rauletorresc force-pushed the implement-mid-circuit-post-selection branch from ca19450 to a15e879 Compare February 2, 2024 01:32

rauletorresc added runtime Pull requests that update the runtime compiler Pull requests that update the compiler frontend Pull requests that update the frontend labels Feb 2, 2024

maliasadi reviewed Feb 2, 2024

View reviewed changes

rauletorresc force-pushed the implement-mid-circuit-post-selection branch from a15e879 to 3e3cf85 Compare February 2, 2024 16:12

erick-xanadu reviewed Feb 2, 2024

View reviewed changes

mlir/test/Quantum/ConversionTest.mlir Outdated Show resolved Hide resolved

rauletorresc force-pushed the implement-mid-circuit-post-selection branch from 3e3cf85 to fd7543f Compare February 2, 2024 16:30

rmoyard reviewed Feb 2, 2024

View reviewed changes

frontend/catalyst/pennylane_extensions.py Show resolved Hide resolved

frontend/catalyst/pennylane_extensions.py Show resolved Hide resolved

rauletorresc force-pushed the implement-mid-circuit-post-selection branch from 4de4388 to f9d6292 Compare February 5, 2024 18:10

rauletorresc requested review from maliasadi, rmoyard and erick-xanadu February 5, 2024 18:19

rmoyard reviewed Feb 5, 2024

View reviewed changes

mlir/include/Quantum/IR/QuantumOps.td Outdated Show resolved Hide resolved

runtime/lib/backend/lightning/lightning_dynamic/LightningSimulator.cpp Outdated Show resolved Hide resolved

rauletorresc force-pushed the implement-mid-circuit-post-selection branch from b1f66e3 to 54d6d1b Compare February 6, 2024 20:32

rauletorresc marked this pull request as ready for review February 6, 2024 20:36

rauletorresc requested a review from rmoyard February 6, 2024 20:36

erick-xanadu reviewed Feb 7, 2024

View reviewed changes

mlir/test/Quantum/ConversionTest.mlir Outdated Show resolved Hide resolved

maliasadi requested changes Feb 7, 2024

View reviewed changes

dime10 reviewed Feb 7, 2024

View reviewed changes

mlir/test/Quantum/AdjointTest.mlir Outdated Show resolved Hide resolved

rauletorresc force-pushed the implement-mid-circuit-post-selection branch from 54d6d1b to d3519f8 Compare February 8, 2024 03:52

dime10 reviewed Feb 8, 2024

View reviewed changes

mlir/include/Quantum/IR/QuantumOps.td Outdated Show resolved Hide resolved

rauletorresc force-pushed the implement-mid-circuit-post-selection branch from d3519f8 to 466489e Compare February 8, 2024 16:52

dime10 reviewed Feb 8, 2024

View reviewed changes

mlir/include/Quantum/IR/QuantumOps.td Outdated Show resolved Hide resolved

runtime/include/QuantumDevice.hpp Show resolved Hide resolved

rauletorresc force-pushed the implement-mid-circuit-post-selection branch 3 times, most recently from e87962c to 648f03e Compare February 9, 2024 00:57

rauletorresc requested a review from dime10 February 9, 2024 01:14

maliasadi approved these changes Feb 9, 2024

View reviewed changes

rmoyard approved these changes Feb 9, 2024

View reviewed changes

doc/changelog.md Show resolved Hide resolved

frontend/catalyst/pennylane_extensions.py Show resolved Hide resolved

rauletorresc and others added 13 commits February 9, 2024 10:55

Pass trough 'postselect' for mid-circuit measurements

dbf1ca8

Handle 'postselect' in '_qmeasure_lowering' function at the frontend

84d5391

Separating args/kwargs

c685d88

Add comments, formatting and example at the frontend

f725c6a

Fail when the probability of the postselect value is zero

887be73

Add postselect argument to dummy device

5ca8817

Add missing postselect argument to some device tests

a213cc4

Add conversion tests for different postselect values

6dfed9e

Implement the post-selection logic at the runtime side

41f5fb3

Add integration tests for when postselect is given by the user

9d04ada

Allow passing postselect as optional from the frontend to the MLIR

e342183

Add runtime tests for post-selection

70b5a60

Add PR description to changelog.md

c51cef7

rauletorresc force-pushed the implement-mid-circuit-post-selection branch from a05fad7 to c51cef7 Compare February 9, 2024 16:09

rauletorresc requested review from maliasadi and rmoyard February 9, 2024 16:17

maliasadi approved these changes Feb 9, 2024

View reviewed changes

rauletorresc merged commit 0509f9e into main Feb 9, 2024
42 checks passed

rauletorresc deleted the implement-mid-circuit-post-selection branch February 9, 2024 16:52

dime10 reviewed Feb 9, 2024

View reviewed changes

runtime/tests/Test_LightningMeasures.cpp Show resolved Hide resolved

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Implementation of post-selection for mid-circuit measurements #491

Implementation of post-selection for mid-circuit measurements #491

rauletorresc commented Feb 2, 2024 •

edited

Loading

maliasadi left a comment

rmoyard left a comment

rmoyard left a comment

rauletorresc commented Feb 5, 2024

rauletorresc commented Feb 6, 2024 •

edited

Loading

maliasadi left a comment

dime10 left a comment

codecov-commenter commented Feb 9, 2024 •

edited

Loading

maliasadi left a comment

rmoyard left a comment

maliasadi left a comment

Implementation of post-selection for mid-circuit measurements #491

Implementation of post-selection for mid-circuit measurements #491

Conversation

rauletorresc commented Feb 2, 2024 • edited Loading

maliasadi left a comment

Choose a reason for hiding this comment

rmoyard left a comment

Choose a reason for hiding this comment

rmoyard left a comment

Choose a reason for hiding this comment

rauletorresc commented Feb 5, 2024

rauletorresc commented Feb 6, 2024 • edited Loading

maliasadi left a comment

Choose a reason for hiding this comment

dime10 left a comment

Choose a reason for hiding this comment

codecov-commenter commented Feb 9, 2024 • edited Loading

Codecov Report

maliasadi left a comment

Choose a reason for hiding this comment

rmoyard left a comment

Choose a reason for hiding this comment

maliasadi left a comment

Choose a reason for hiding this comment

rauletorresc commented Feb 2, 2024 •

edited

Loading

rauletorresc commented Feb 6, 2024 •

edited

Loading

codecov-commenter commented Feb 9, 2024 •

edited

Loading