-
Notifications
You must be signed in to change notification settings - Fork 34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add instrumentation to Catalyst's frontend #597
Conversation
Hello. You may have forgotten to update the changelog!
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #597 +/- ##
==========================================
- Coverage 99.15% 98.26% -0.90%
==========================================
Files 64 65 +1
Lines 9259 9387 +128
Branches 719 735 +16
==========================================
+ Hits 9181 9224 +43
- Misses 51 135 +84
- Partials 27 28 +1 ☔ View full report in Codecov by Sentry. |
- cap precision to 1 microsecond - pad timings to 12 characters
...between the Python layer and C++ layer.
.. in order to match the C++ layer. Handling 2 different streams makes testing difficult.
as it is unreliable/implementation defined when, or if, this method is called.
@maliasadi Could you have a look? I'll add some tests as well to complete the coverage. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @dime10! Nothing more from my side 🎉
Don't forget to update the changelog before merge :)
output in console mode. This is particularly important since the fine-grained output is printed first, so the coarsegrained results are represented as a "total" underneath.
The runtime did not use the `timer` function wrapper which checks wether instrumentation is enabled on each call. Instead, a single global timer instance is used which only checks the enabled status once when the runtime library is first loaded into Python. This would mean that the runtime output could not be obtained during any Python session that already ran atleast one compiled function.
Adds frontend instrumentation to QJIT class methods. To use the instrumentation a session needs to be started:
Example output (YAML):
Example output (console):
[sc-62132]