Callbacks with return values #610
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #610 +/- ##
=======================================
Coverage 99.41% 99.41%
=======================================
Files 54 55 +1
Lines 9053 9109 +56
Branches 684 694 +10
=======================================
+ Hits 9000 9056 +56
Misses 28 28
Partials 25 25 ☔ View full report in Codecov by Sentry. |
erick-xanadu
force-pushed
the
eochoa/2024-03-08/callbacks-parameters
branch
from
659b5d3
to
8cf8b3a
Compare
erick-xanadu
force-pushed
the
eochoa/2024-03-14/callbacks-with-return-values
branch
from
9cfb321
to
229b4e6
Compare
erick-xanadu
changed the title
This reverts commit cbb42a1.
erick-xanadu
force-pushed
the
eochoa/2024-03-14/callbacks-with-return-values
branch
from
e6e7293
to
d28e199
Compare
rmoyard
reviewed
Apr 1, 2024
There was a problem hiding this comment.
Thanks @erick-xanadu, it looks good! I have left some questions. Could you also add a call back test (e2e in python) of a more elaborated function?
dime10
reviewed
Apr 1, 2024
Co-authored-by: David Ittah <dime10@users.noreply.github.com>
mlxd
reviewed
Apr 5, 2024
Co-authored-by: Lee James O'Riordan <mlxd@users.noreply.github.com>
mlxd
approved these changes
Apr 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context: Adds support for callbacks with return values.
Description of the Change: The callback will flatten the returns and cast them to unranked_memrefs. The unranked_memrefs are copied over using mlir_c_runner's library.
Benefits: Callbacks may have return values
Possible Drawbacks: None.
Related GitHub Issues: None.
[sc-47690]