Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix tests for OpenQasm device #620

Merged
merged 2 commits into from
Mar 20, 2024
Merged

Conversation

erick-xanadu
Copy link
Contributor

Context: Recent changes in Amazon's Braket SDK made measurements behave differently. Now it returns all qubits in a qubit array where previously it appeared to return only alived qubits. (In other words, dead code elimination removed extra qubits but now it doesn't apppear to be the case).

Description of the Change: Change the test to only create a qubit array of 2 values instead of 5.

Benefits: The OpenQASM device tests are now passing.

Possible Drawbacks: None.

Related GitHub Issues: None.

@erick-xanadu erick-xanadu marked this pull request as ready for review March 19, 2024 21:47
Copy link
Contributor

@rauletorresc rauletorresc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rmoyard rmoyard merged commit 0a3d6da into main Mar 20, 2024
38 checks passed
@rmoyard rmoyard deleted the eochoa/2024-03-19/amazon-braket branch March 20, 2024 02:35
erick-xanadu added a commit that referenced this pull request Apr 9, 2024
**Context:** Recent changes in Amazon's Braket SDK made measurements
behave differently. Now it returns all qubits in a qubit array where
previously it appeared to return only alived qubits. (In other words,
dead code elimination removed extra qubits but now it doesn't apppear to
be the case).

**Description of the Change:** Change the test to only create a qubit
array of 2 values instead of 5.

**Benefits:** The OpenQASM device tests are now passing.

**Possible Drawbacks:** None.

**Related GitHub Issues:** None.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants