Make shallow circuit demo Catalyst-Compatible #816
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hello. You may have forgotten to update the changelog!
|
josh146
reviewed
Jun 18, 2024
|
Just a note that codecov/project coverage failure usually means (a) the feature branch's new feature is not covered by a new test and/or (b) the feature branch is out of sync with main branch. |
dime10
requested changes
Jun 20, 2024
tzunghanjuang
force-pushed
the
learningshallow-demo
branch
from
8293cc5
to
6daacb7
Compare
tzunghanjuang
commented
Jun 20, 2024
dime10
reviewed
Jul 4, 2024
Co-authored-by: David Ittah <dime10@users.noreply.github.com>
Co-authored-by: David Ittah <dime10@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context:
Convert Shallow Circuit Demo into a Catalyst-compatiable one.
Description of the Change: Mainly replace
jax.jitwithqjit. However, it introduces errors related tofunctools.partial(#814 and #815). Right now I circumvent the errors by avoiding usingfunctools.partial. Will open the other PRs to fix the issues.optaxoptimizers, we usepytreeto handle such information.optaxfrom the AutoGraph conversion.Related GitHub Issues:
[sc-65901]