Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move validation functions to verification file in device #848

Merged
merged 3 commits into from
Jun 21, 2024

Conversation

lillian542
Copy link
Contributor

@lillian542 lillian542 commented Jun 21, 2024

Context
We have an empty verification.py file in the device module that was intended as the long-term location of validation functions.

Description of change
Copy-pasted all the validation from programs/verification.py into device/verification.py, and changed import paths

Copy link

codecov bot commented Jun 21, 2024

Codecov Report

Attention: Patch coverage is 99.25373% with 1 line in your changes missing coverage. Please review.

Project coverage is 98.01%. Comparing base (1712396) to head (af65355).
Report is 201 commits behind head on main.

Files with missing lines Patch % Lines
frontend/catalyst/device/verification.py 99.24% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main     #848   +/-   ##
=======================================
  Coverage   98.01%   98.01%           
=======================================
  Files          71       71           
  Lines       10429    10429           
  Branches      936      936           
=======================================
  Hits        10222    10222           
  Misses        166      166           
  Partials       41       41           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@dime10 dime10 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

perfect 👍

Copy link
Contributor

Hello. You may have forgotten to update the changelog!
Please edit doc/changelog.md on your branch with:

  • A one-to-two sentence description of the change. You may include a small working example for new features.
  • A link back to this PR.
  • Your name (or GitHub username) in the contributors section.

@lillian542 lillian542 merged commit 8c191be into main Jun 21, 2024
42 checks passed
@lillian542 lillian542 deleted the move_verification branch June 21, 2024 22:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants