Restore batching memory control functionality to LightningGPU #564
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mlxd
added
the
ci:use-multi-gpu-runner
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #564 +/- ##
==========================================
+ Coverage 98.69% 98.92% +0.23%
==========================================
Files 168 202 +34
Lines 22585 27272 +4687
==========================================
+ Hits 22290 26980 +4690
+ Misses 295 292 -3 ☔ View full report in Codecov by Sentry. |
…lightning into fix_lgpu_batching
…lightning into fix_lgpu_batching
| const auto first = static_cast<std::size_t>( | ||
| std::ceil(obs.size() * i / num_chunks)); | ||
|
|
||
| auto jac_chunk = futures[i].get(); | ||
| auto jac_chunk = jac_futures[i].get(); | ||
| for (std::size_t j = 0; j < jac_chunk.size(); j++) { | ||
| std::copy(jac_chunk.begin(), jac_chunk.end(), |
There was a problem hiding this comment.
As we would like to use the incoming jac span? Can we add a //TODO here for it?
multiphaseCFD
approved these changes
Nov 24, 2023
AmintorDusko
approved these changes
Nov 24, 2023
| @@ -52,9 +52,12 @@ class QuantumScriptSerializer: | |||
| """ | |||
There was a problem hiding this comment.
To keep note, the class docstring is incomplete. It was missing use_mpi and now split_obs.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before submitting
Please complete the following checklist when submitting a PR:
All new features must include a unit test.
If you've fixed a bug or added code that should be tested, add a test to the
testsdirectory!All new functions and code must be clearly commented and documented.
If you do make documentation changes, make sure that the docs build and
render correctly by running
make docs.Ensure that the test suite passes, by running
make test.Add a new entry to the
.github/CHANGELOG.mdfile, summarizing thechange, and including a link back to the PR.
Ensure that code is properly formatted by running
make format.When all the above are checked, delete everything above the dashed
line and fill in the pull request template.
Context: This PR fixes batching support for LightningGPU devices, and adds preliminary support to enable it for LQ and LK at a later date.
Description of the Change:
Benefits:
Possible Drawbacks:
Related GitHub Issues: