Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No backprop devices #61

Merged
merged 11 commits into from
Feb 9, 2021
Merged

No backprop devices #61

merged 11 commits into from
Feb 9, 2021

Conversation

antalszava
Copy link
Contributor

@antalszava antalszava commented Feb 9, 2021

Context

As lighting.qubit inherits from default.qubit, it also inherits the passthru_devices entry of the device.capabilities dictionary.

This, however, may lead to unexpected behaviour, as the QNode in PennyLane attempts to get a device with the best differentiation method available. Therefore, even without specifying a differentiation method, we may get a default.qubit.autograd device.

Changes

Removes the passthru_devices entry of device.capabilities.

@codecov
Copy link

codecov bot commented Feb 9, 2021

Codecov Report

Merging #61 (bffde19) into master (451f2df) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##            master       #61   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            3         3           
  Lines           54        54           
=========================================
  Hits            54        54           
Impacted Files Coverage Δ
pennylane_lightning/lightning_qubit.py 100.00% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 451f2df...99f073a. Read the comment docs.

@josh146
Copy link
Member

josh146 commented Feb 9, 2021

Didn't seem to fix the windows wheel :(

@antalszava antalszava changed the title No backprop defs No backprop devices Feb 9, 2021
@antalszava antalszava marked this pull request as ready for review February 9, 2021 16:47
Copy link
Member

@josh146 josh146 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for getting onto this so quickly @antalszava! Before merging, don't forget to update the changelog.

tests/test_apply.py Outdated Show resolved Hide resolved
tests/test_apply.py Show resolved Hide resolved
antalszava and others added 3 commits February 9, 2021 12:13
Co-authored-by: Josh Izaac <josh146@gmail.com>
@antalszava antalszava added the bug Something isn't working label Feb 9, 2021
@antalszava antalszava merged commit 35d8d18 into master Feb 9, 2021
@antalszava antalszava deleted the no_passthru branch February 9, 2021 18:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants