Remove set_parameters and data setter from qscript #4548
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lillian542
commented
Aug 29, 2023
|
[sc-43899] |
…ane into remove_set_parameters
Codecov ReportPatch coverage has no change and project coverage change:
Additional details and impacted files@@ Coverage Diff @@
## master #4548 +/- ##
==========================================
- Coverage 99.66% 99.66% -0.01%
==========================================
Files 376 376
Lines 33072 33047 -25
==========================================
- Hits 32962 32937 -25
Misses 110 110
☔ View full report in Codecov by Sentry. |
timmysilv
reviewed
Aug 29, 2023
timmysilv
approved these changes
Aug 29, 2023
Co-authored-by: Matthew Silverman <matthews@xanadu.ai>
mudit2812
approved these changes
Aug 30, 2023
albi3ro
reviewed
Aug 30, 2023
lillian542
commented
Aug 31, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Completes deprecation cycle for
QuantumScript.set_parametersandQuantumScript.data