Improving interface determination in pauli_decompose
#4577
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
can you give an example for when this happens? I'm guessing something like batched matrices in a list? Perhaps a test would help highlight what you're fixing. While we're here, what was this line intended to do before this change? |
|
A very simple example might be the following - |
timmysilv
approved these changes
Sep 8, 2023
DSGuala
approved these changes
Sep 8, 2023
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #4577 +/- ##
=======================================
Coverage 99.64% 99.64%
=======================================
Files 376 376
Lines 33123 33123
=======================================
Hits 33007 33007
Misses 116 116
☔ View full report in Codecov by Sentry. |
mudit2812
pushed a commit
that referenced
this pull request
Sep 12, 2023
**Context:** Improving support for determining the `non-numpy` interfaces when enclosed within builtin types. **Description of the Change:** We use `next(iter([*matrix[0]]), []))` instead of `matrix` to determine the interface to work with. **Benefits:** All interfaces are identified correctly for the provided matrix object. **Possible Drawbacks:** None **Related GitHub Issues:** None
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context: Improving support for determining the
non-numpyinterfaces when enclosed within builtin types.Description of the Change: We use
next(iter([*matrix[0]]), []))instead ofmatrixto determine the interface to work with.Benefits: All interfaces are identified correctly for the provided matrix object.
Possible Drawbacks: None
Related GitHub Issues: None