AmplitudeEmbedding inherits from StatePrep #4583
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
timmysilv
commented
Sep 8, 2023
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #4583 +/- ##
==========================================
- Coverage 99.64% 99.64% -0.01%
==========================================
Files 376 376
Lines 33247 33238 -9
==========================================
- Hits 33128 33119 -9
Misses 119 119
☔ View full report in Codecov by Sentry. |
|
[sc-44390] |
mudit2812
approved these changes
Sep 8, 2023
# Conflicts: # tests/tape/test_tape.py
Jaybsoni
reviewed
Sep 12, 2023
Jaybsoni
reviewed
Sep 12, 2023
# Conflicts: # doc/releases/changelog-dev.md
timmysilv
changed the title
Jaybsoni
approved these changes
Sep 13, 2023
mudit2812
approved these changes
Sep 13, 2023
mudit2812
pushed a commit
that referenced
this pull request
Sep 15, 2023
**Context:** While porting DQ2, the merge_amplitude_embedding tests were failing because `AmplitudeEmbedding` was being decomposed. I figured that since it behaves like a `StatePrep` op, we should make it inherit from it and gain the benefit! **Description of the Change:** `AmplitudeEmbedding` inherits from `StatePrep`, gaining its `state_vector` implementation and various properties. The only real change now that it inherits from `StatePrep` is that it will return True for `isinstance(op, StatePrep)` checks but I think this is not a problem. **Benefits:** `AmplitudeEmbedding` will behave the same on DQ2 as it did on DQL (it would decompose once to `StatePrep`, then be "supported" by DQL, and then it would have the custom apply function - on DQ2, it was decomposing all the way, and then I hit a bug where it thought it could support batching but the full decomposition disagreed). I confirmed locally that all changed tests, `test_amplitude.py`, and `test_merge_amplitude_embeddings.py` all passed with DQ2 as well. **Possible Drawbacks:** If someone somehow calls `expand_tape_state_prep` with `AmplitudeEmbedding` and `skip_first=False`, it will decompose once to a `StatePrep` and call it a day. This is reflected in tests, but I figured it shouldn't be too much of a concern... users don't even have a way to set `skip_first` to False (...yet?)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context:
While porting DQ2, the merge_amplitude_embedding tests were failing because
AmplitudeEmbeddingwas being decomposed. I figured that since it behaves like aStatePrepop, we should make it inherit from it and gain the benefit!Description of the Change:
AmplitudeEmbeddinginherits fromStatePrep, gaining itsstate_vectorimplementation and various properties.The only real change now that it inherits from
StatePrepis that it will return True forisinstance(op, StatePrep)checks but I think this is not a problem.Benefits:
AmplitudeEmbeddingwill behave the same on DQ2 as it did on DQL (it would decompose once toStatePrep, then be "supported" by DQL, and then it would have the custom apply function - on DQ2, it was decomposing all the way, and then I hit a bug where it thought it could support batching but the full decomposition disagreed). I confirmed locally that all changed tests,test_amplitude.py, andtest_merge_amplitude_embeddings.pyall passed with DQ2 as well.Possible Drawbacks:
If someone somehow calls
expand_tape_state_prepwithAmplitudeEmbeddingandskip_first=False, it will decompose once to aStatePrepand call it a day. This is reflected in tests, but I figured it shouldn't be too much of a concern... users don't even have a way to setskip_firstto False (...yet?)