Add prng_key kwarg to new device API #4596
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hello. You may have forgotten to update the changelog!
|
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #4596 +/- ##
=======================================
Coverage 99.64% 99.64%
=======================================
Files 375 375
Lines 33370 33398 +28
=======================================
+ Hits 33252 33280 +28
Misses 118 118
☔ View full report in Codecov by Sentry. |
|
[sc-44393] |
timmysilv
approved these changes
Sep 15, 2023
Co-authored-by: Matthew Silverman <matthews@xanadu.ai>
trbromley
reviewed
Sep 18, 2023
lillian542
commented
Sep 18, 2023
mudit2812
approved these changes
Sep 18, 2023
trbromley
reviewed
Sep 18, 2023
albi3ro
reviewed
Sep 18, 2023
mudit2812
pushed a commit
that referenced
this pull request
Sep 20, 2023
**Context:** The `default.qubit.jax` device can take a `prng_key`, and if it does, it returns the same results from sampling any given state across repeated measurements, rather than randomizing the sampling of the state. **Description of the Change:** Allow the `seed` on `DefaultQubit2` to be a `jax.random.PRNGKey`; if it is, have the new device replicate the `DefaultQubitJax` sampling behaviour. **Benefits:** You can get the same behaviour on the new device if you want a set PRNG key when using `jax`. **Possible Drawbacks:** Previously, the jax device would use `jax.choice` to generate samples regardless of whether or not a PRNG key was provided; the difference was whether it used a new random PRNG key each time, or the same one over and over. For the new DefaultQubit, if you provide a PRNG key as the seed, the behaviour will be the same as the `default.qubit.jax` device with a set `prng_key`. If you leave the seed as None or an integer, even if the interface is `jax`, it will use the `numpy.random.default_rng` to generate the samples, and not `jax.choice`. If you want a random PRNGKey and `jax.choice`, you can fix it by reinitializing the device each time you run, with a randomly generated PRNG key as the seed. --------- Co-authored-by: Matthew Silverman <matthews@xanadu.ai>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context:
The
default.qubit.jaxdevice can take aprng_key, and if it does, it returns the same results from sampling any given state across repeated measurements, rather than randomizing the sampling of the state.Description of the Change:
Allow the
seedonDefaultQubit2to be ajax.random.PRNGKey; if it is, have the new device replicate theDefaultQubitJaxsampling behaviour.Benefits:
You can get the same behaviour on the new device if you want a set PRNG key when using
jax.Possible Drawbacks:
Previously, the jax device would use
jax.choiceto generate samples regardless of whether or not a PRNG key was provided; the difference was whether it used a new random PRNG key each time, or the same one over and over.For the new DefaultQubit, if you provide a PRNG key as the seed, the behaviour will be the same as the
default.qubit.jaxdevice with a setprng_key. If you leave the seed as None or an integer, even if the interface isjax, it will use thenumpy.random.default_rngto generate the samples, and notjax.choice.If you want a random PRNGKey and
jax.choice, you can fix it by reinitializing the device each time you run, with a randomly generated PRNG key as the seed.