Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

un-relax pylint rules in convert.py #4634

Merged
merged 11 commits into from
Sep 28, 2023
Merged

Conversation

Chiffafox
Copy link
Contributor

@Chiffafox Chiffafox commented Sep 27, 2023

Context:

Small change to the pylint rules in convert.py

Description of the Change:

In convert.py, pylint now only relaxes the no top level imports rule.

Benefits:

Possible Drawbacks:

Related GitHub Issues:

@Chiffafox Chiffafox marked this pull request as ready for review September 27, 2023 14:41
@codecov
Copy link

codecov bot commented Sep 27, 2023

Codecov Report

All modified lines are covered by tests ✅

Comparison is base (db5b792) 99.63% compared to head (98d58d0) 99.63%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #4634      +/-   ##
==========================================
- Coverage   99.63%   99.63%   -0.01%     
==========================================
  Files         376      376              
  Lines       33618    33616       -2     
==========================================
- Hits        33494    33492       -2     
  Misses        124      124              
Files Coverage Δ
pennylane/qchem/convert.py 100.00% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@trbromley trbromley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @Chiffafox!

@Chiffafox Chiffafox enabled auto-merge (squash) September 28, 2023 19:00
@Chiffafox Chiffafox merged commit 9a83734 into master Sep 28, 2023
38 checks passed
@Chiffafox Chiffafox deleted the dmrg_shci_impstate_pylintfix branch September 28, 2023 19:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants