New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Transform for Clifford+T decomposition #4655

Closed

obliviateandsurrender wants to merge 58 commits into master from clifford+t_tranform

Contributor

obliviateandsurrender commented Oct 6, 2023

Context: Adds a transform to perform Clifford+T decomposition

Description of the Change: Unrolls the circuit into Clifford+Rotation basis and then uses the functionality to obtain approximations for arbitrary z-rotations up to arbitrary ϵ for the operations.

Benefits: Allows one to transform any random circuit to a Clifford+Phase basis.

Possible Drawbacks: Might be sub-optimal

Related GitHub Issues:

timmysilv and others added 10 commits

October 2, 2023 11:18


          up to diophantine without rings

8feecd3


          start using custom types

e13b859


          transform init

c7837f5


          get non-infinite reduction; still wrong result

8099f74


          working reduction

3cbc61f


          Merge branch 'master' into clifford-t-decomp

7557cb1


          Merge branch 'clifford-t-decomp' of https://github.com/PennyLaneAI/pe…

bd21c1d

…nnylane into clifford-t-decomp


          add transform

129fc27


          revert changes to matt branch

87f8396


          add transform

3c85262

Contributor

github-actions bot commented Oct 6, 2023

Hello. You may have forgotten to update the changelog!
Please edit doc/releases/changelog-dev.md with:

A one-to-two sentence description of the change. You may include a small working example for new features.
A link back to this PR.
Your name (or GitHub username) in the contributors section.

obliviateandsurrender added 2 commits

October 6, 2023 11:18


          use GlobalPhase

3ff9de4


          happy black

db073a6

trbromley reviewed

View reviewed changes

pennylane/ops/qubit/parametric_ops_single_qubit.py Outdated Show resolved Hide resolved

obliviateandsurrender added 2 commits

October 6, 2023 12:47


          fix tests

3df7afb


          fix more tests

69ea019

Contributor Author

obliviateandsurrender commented Oct 6, 2023

obliviateandsurrender added 4 commits

October 6, 2023 13:52


          Merge branch 'phase_gate_decompose' of https://github.com/PennyLaneAI…

acd3a78

…/pennylane into clifford+t_tranform


          happy pylint

741dc45


          happier pylint

5f6c5e5


          fix tests

7bdabcf

codecov bot commented Oct 6, 2023 •

edited

Loading

Codecov Report

Attention: 2 lines in your changes are missing coverage. Please review.

Comparison is base (c899d6d) 99.64% compared to head (73b5f6e) 99.63%.
Report is 2 commits behind head on master.

Additional details and impacted files

@@            Coverage Diff             @@
##           master    #4655      +/-   ##
==========================================
- Coverage   99.64%   99.63%   -0.01%     
==========================================
  Files         380      382       +2     
  Lines       34275    34260      -15     
==========================================
- Hits        34154    34136      -18     
- Misses        121      124       +3

Files	Coverage Δ
pennylane/__init__.py	`100.00% <ø> (ø)`
pennylane/transforms/__init__.py	`100.00% <100.00%> (ø)`
...nsforms/decompositions/clifford_plus_t/__init__.py	`100.00% <100.00%> (ø)`
...lane/transforms/optimization/optimization_utils.py	`100.00% <100.00%> (ø)`
...ompositions/clifford_plus_t/cliffordt_transform.py	`98.96% <98.96%> (ø)`

... and 45 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

trbromley reviewed

View reviewed changes

pennylane/transforms/decompositions/clifford_plus_t/cliffordt_transform.py Outdated Show resolved Hide resolved

trbromley reviewed

View reviewed changes

Contributor

trbromley left a comment

Thanks @obliviateandsurrender! Let me know if I can help clarify any of the comments.

pennylane/transforms/decompositions/clifford_plus_t/cliffordt_transform.py Outdated Show resolved Hide resolved

pennylane/transforms/decompositions/clifford_plus_t/cliffordt_transform.py Show resolved Hide resolved

pennylane/transforms/decompositions/clifford_plus_t/cliffordt_transform.py Show resolved Hide resolved

pennylane/transforms/decompositions/clifford_plus_t/cliffordt_transform.py Outdated Show resolved Hide resolved

pennylane/transforms/decompositions/clifford_plus_t/cliffordt_transform.py Show resolved Hide resolved

pennylane/transforms/decompositions/clifford_plus_t/cliffordt_transform.py Outdated Show resolved Hide resolved


          add tests

albi3ro reviewed

View reviewed changes

pennylane/transforms/decompositions/clifford_plus_t/cliffordt_transform.py Outdated Show resolved Hide resolved

albi3ro reviewed

View reviewed changes

pennylane/transforms/decompositions/clifford_plus_t/cliffordt_transform.py Outdated Show resolved Hide resolved

albi3ro reviewed

View reviewed changes

pennylane/transforms/decompositions/clifford_plus_t/cliffordt_transform.py Outdated Show resolved Hide resolved

albi3ro reviewed

View reviewed changes

pennylane/transforms/decompositions/clifford_plus_t/cliffordt_transform.py Show resolved Hide resolved


          add review suggestions and tests

c5155cb

obliviateandsurrender added 20 commits

October 11, 2023 20:13


          try CI fix

87ea713


          skip decompositions

86e93e9


          tweak tests and fix basis_set

16e1bc3


          add qnode test

dfbea58


          add tests

1e23785


          add pragma

9ca0419


          add docs

3ce93fb


          tweak docs

013eb06


          improve docs

1c71112


          fix black

8bf09a6


          fix pylint

8527e02


          tweak docs

8ae7435


          intializing methods for solovay-kitaev

476d46a


          undo last commit

4ecc48b


          fix tape execution

3c3b309


          Merge branch 'master' of https://github.com/PennyLaneAI/pennylane int…

1472c7a

…o clifford+t_tranform


          Merge branch 'master' of https://github.com/PennyLaneAI/pennylane int…

86778e6

…o clifford+t_tranform


          add solovay-kitaev to transform

c6fde9c


          happy 'black'

2daf9ef


          happy codefactor

cc703f5

obliviateandsurrender requested a review from timmysilv

October 20, 2023 18:56

obliviateandsurrender added 2 commits

October 20, 2023 15:08


          happy pylint

df44f11


          whitespaces

73b5f6e

DSGuala reviewed

View reviewed changes

Contributor

DSGuala left a comment

Reviewed docs. Will look at code now.

pennylane/transforms/__init__.py Outdated Show resolved Hide resolved

pennylane/transforms/decompositions/clifford_plus_t/cliffordt_transform.py Outdated Show resolved Hide resolved

pennylane/transforms/decompositions/clifford_plus_t/cliffordt_transform.py Outdated Show resolved Hide resolved

pennylane/transforms/decompositions/clifford_plus_t/cliffordt_transform.py Outdated Show resolved Hide resolved

pennylane/transforms/decompositions/clifford_plus_t/cliffordt_transform.py Show resolved Hide resolved

pennylane/transforms/decompositions/clifford_plus_t/cliffordt_transform.py

+                  Args:
+                      qfunc (function): A quantum function
+                      max_depth (int): The depth to use for tape expansion before manual decomposition to Clifford+T basis is applied

Contributor

DSGuala Oct 20, 2023

Suggested change

      
                    max_depth (int): The depth to use for tape expansion before manual decomposition to Clifford+T basis is applied
          
                    max_depth (int): How many times the tape is expanded before manual decomposition to Clifford+T basis is applied

Also, what does manual decomposition mean here?

Contributor Author

obliviateandsurrender Oct 20, 2023

It means the actual decomposition to the Clifford+T basis.

pennylane/transforms/decompositions/clifford_plus_t/cliffordt_transform.py

Comment on lines +313 to +314

		Keyword Args:
		Arguments (*):

Contributor

DSGuala Oct 20, 2023

This looks kind of strange in the preview. Could it just say "Keyword Args:" and not include "Arguments (*):"?

Contributor Author

obliviateandsurrender Oct 20, 2023

I am doing so to escape making a big list of kwargs for individual items. I couldn't find another way to do it.

pennylane/transforms/decompositions/clifford_plus_t/cliffordt_transform.py

+                  Args:
+                      qfunc (function): A quantum function
+                      max_depth (int): The depth to use for tape expansion before manual decomposition to Clifford+T basis is applied
+                      method (str): Method to be used for Clifford+T decomposition. Default value is ``"sk"`` for Solovay-Kitaev

Contributor

DSGuala Oct 20, 2023

Solovay-Kitaev is the only method for now, but planning to add the other one later?

Contributor Author

obliviateandsurrender Oct 20, 2023

Yes, at least I hope so!

pennylane/transforms/decompositions/clifford_plus_t/cliffordt_transform.py

+                      ValueError: If any gate operation does not have any existing rule for its decomposition
+                      NotImplementedError: If chosen decomposition is not supported
+                  .. seealso:: :func:`~.sk_decomposition` and :func:`~.sk_approximate_set`

Contributor

DSGuala Oct 20, 2023

Can we also have an example? 🙏

pennylane/transforms/decompositions/clifford_plus_t/cliffordt_transform.py Outdated Show resolved Hide resolved

timmysilv reviewed

View reviewed changes

Contributor

timmysilv left a comment

mostly looks good! i have a weird feeling that we're missing some testing to be sure it's totally ready but it's not coming to me

pennylane/transforms/decompositions/clifford_plus_t/cliffordt_transform.py

+                          next_gate_idx = find_next_gate(curr_gate.wires, copied_ops[1:])
+                      # Replace the current gate, add it to merged list and pop it from orginal one
+                      merged_ops.append(curr_gate.__class__(*cumulative_angles, wires=curr_gate.wires))

Contributor

timmysilv Oct 20, 2023

this is probably better for this use-case, but in general you may want to use bind_new_parameters

pennylane/transforms/decompositions/clifford_plus_t/cliffordt_transform.py Show resolved Hide resolved

pennylane/transforms/decompositions/clifford_plus_t/cliffordt_transform.py Outdated Show resolved Hide resolved

pennylane/transforms/decompositions/clifford_plus_t/cliffordt_transform.py Outdated Show resolved Hide resolved

tests/transforms/test_clifford_t/test_cliffordt_transform.py Outdated Show resolved Hide resolved

tests/transforms/test_clifford_t/test_cliffordt_transform.py Show resolved Hide resolved

tests/transforms/test_clifford_t/test_cliffordt_transform.py Outdated Show resolved Hide resolved

tests/transforms/test_clifford_t/test_cliffordt_transform.py

+                      matrix_op = reduce(
+                          lambda x, y: x @ y, [qml.matrix(op) for op in decomp_ops][::-1]
+                      ) * qml.matrix(global_ops)

Contributor

timmysilv Oct 20, 2023

should it not be this?

Suggested change

      
                    ) * qml.matrix(global_ops)
          
                    ) @ qml.matrix(global_ops)

Contributor Author

obliviateandsurrender Oct 20, 2023

The matrix for GlobalPhase is like this ([[phase]]), so I think the latter would throw an error.

trbromley added the do not merge ⚠️ label

obliviateandsurrender added 2 commits

October 20, 2023 16:28


          address comments

2b0db7d


          happy black

d4e15b6

trbromley closed this

mlxd deleted the clifford+t_tranform branch

October 20, 2023 20:43

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

do not merge ⚠️