Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Recreate CtrlSequence PR #4707

Merged
merged 4 commits into from
Oct 23, 2023
Merged

Recreate CtrlSequence PR #4707

merged 4 commits into from
Oct 23, 2023

Conversation

mlxd
Copy link
Member

@mlxd mlxd commented Oct 23, 2023

Before submitting

Please complete the following checklist when submitting a PR:

  • All new features must include a unit test.
    If you've fixed a bug or added code that should be tested, add a test to the
    test directory!

  • All new functions and code must be clearly commented and documented.
    If you do make documentation changes, make sure that the docs build and
    render correctly by running make docs.

  • Ensure that the test suite passes, by running make test.

  • Add a new entry to the doc/releases/changelog-dev.md file, summarizing the
    change, and including a link back to the PR.

  • The PennyLane source code conforms to
    PEP8 standards.
    We check all of our code against Pylint.
    To lint modified files, simply pip install pylint, and then
    run pylint pennylane/path/to/file.py.

When all the above are checked, delete everything above the dashed
line and fill in the pull request template.


Context: Recreate the CtrlSequence PR.

Description of the Change:

Benefits:

Possible Drawbacks:

Related GitHub Issues:

@github-actions
Copy link
Contributor

Hello. You may have forgotten to update the changelog!
Please edit doc/releases/changelog-dev.md with:

  • A one-to-two sentence description of the change. You may include a small working example for new features.
  • A link back to this PR.
  • Your name (or GitHub username) in the contributors section.

@mlxd mlxd marked this pull request as ready for review October 23, 2023 15:14
@lillian542
Copy link
Contributor

[sc-45846]

@codecov
Copy link

codecov bot commented Oct 23, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (a7114a9) 99.64% compared to head (fdeaa5f) 99.64%.
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #4707      +/-   ##
==========================================
- Coverage   99.64%   99.64%   -0.01%     
==========================================
  Files         379      380       +1     
  Lines       34126    33972     -154     
==========================================
- Hits        34005    33850     -155     
- Misses        121      122       +1     
Files Coverage Δ
pennylane/_device.py 99.41% <100.00%> (+<0.01%) ⬆️
pennylane/devices/default_qubit.py 100.00% <100.00%> (ø)
pennylane/devices/qubit/sampling.py 100.00% <100.00%> (ø)
pennylane/devices/qubit/simulate.py 100.00% <100.00%> (ø)
pennylane/drawer/draw.py 100.00% <100.00%> (ø)
pennylane/math/single_dispatch.py 99.48% <100.00%> (+<0.01%) ⬆️
pennylane/measurements/mid_measure.py 100.00% <100.00%> (ø)
pennylane/operation.py 97.27% <100.00%> (-0.02%) ⬇️
pennylane/ops/op_math/composite.py 100.00% <100.00%> (ø)
pennylane/ops/op_math/controlled.py 99.63% <ø> (-0.01%) ⬇️
... and 7 more

... and 39 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mlxd mlxd added the merge-ready ✔️ All tests pass and the PR is ready to be merged. label Oct 23, 2023
@mlxd mlxd added this to the v0.33 milestone Oct 23, 2023
@mudit2812 mudit2812 enabled auto-merge (squash) October 23, 2023 18:30
@mudit2812 mudit2812 merged commit b24d6a6 into master Oct 23, 2023
33 checks passed
@mudit2812 mudit2812 deleted the readd_ctrlsequence branch October 23, 2023 18:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
merge-ready ✔️ All tests pass and the PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants