A user-friendlier compilation error for SDMMC_HOST #172
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PerMalmberg
reviewed
Jun 18, 2022
| @@ -18,6 +18,11 @@ limitations under the License. | |||
| #pragma once | |||
|
|
|||
| #include "SDCard.h" | |||
|
|
|||
| #ifndef SOC_SDMMC_HOST_SUPPORTED | |||
| #error "Your chip does not support SDMCC_HOST. See https://github.com/PerMalmberg/Smooth/issues/171" | |||
There was a problem hiding this comment.
Perhaps reference some applicable IDF documentation instead?
There was a problem hiding this comment.
That's a good idea, but I'm not sure how to implement it.
SOC_SDMMC_HOST_SUPPORTED is described on chip-specific pages, e.g.
https://docs.espressif.com/projects/esp-idf/en/latest/esp32/api-reference/system/soc_caps.html
https://docs.espressif.com/projects/esp-idf/en/latest/esp32c3/api-reference/system/soc_caps.html
Correct URL can be computed by inserting CONFIG_IDF_TARGET into the error message, but I don't know how to do that inside the #error.
paulftw
commented
Jun 23, 2022
|
My second commit dropped the |
|
(nevermind, deleted) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #171