Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restyle info row #4

Closed
C84186 opened this issue Jul 21, 2021 · 1 comment · Fixed by #6
Closed

Restyle info row #4

C84186 opened this issue Jul 21, 2021 · 1 comment · Fixed by #6

Comments

@C84186
Copy link
Contributor

C84186 commented Jul 21, 2021

Migrated request to make info row optional to #5

2 Changing the presentation of the rating / download links:

A few options:

2a: inline, & consistent with the "Genre" subheading:

  • In-line
  • De-emphasised & coloured the same
  • The actual links either use images, or just be styled differently from the title.

Here's a quick mockup:

image

In reality, all this involved was changing the markup a little - I removed a <br> element, overwrote some inline styles to match the "Western" text, and added font-weight: lighter; to the link inline styles.

2b: As an extra column

This is probably the most "Polished" looking option, but might run into compatibility issues with other, similar userscripts, such as the magnet link script I mentioned earlier. From a quick review of their code, it looks like they insert their html elements using hardcoded indices, which isn't particularly resilient to changes in the markup.

Personally, I think it would probably be more robust to use the URL order-by parameters from the header row to find the insertion point, but also, that's harder, and these are just user scripts lol.

@C84186
Copy link
Contributor Author

C84186 commented Jul 21, 2021

Personally, my needs would be satisfied by just implementing 2a, which I'm happy enough to do.

I'll probably mix-in the use of image based-download links, to cut down on horizontal space, & maybe replace the text "Rating:" with an image.

@C84186 C84186 changed the title Consider an option to remove the extra line + links for each row Make info row optional, restyle Jul 21, 2021
@C84186 C84186 mentioned this issue Jul 21, 2021
3 tasks
@C84186 C84186 changed the title Make info row optional, restyle Restyle info row Jul 21, 2021
C84186 added a commit to C84186/RARBGHelper that referenced this issue Jul 21, 2021
@PeratX PeratX closed this as completed in #6 Jul 21, 2021
PeratX pushed a commit that referenced this issue Jul 21, 2021
* Restyle info row to be inline

Resolves #4

* Re-add @updateURL metadata

I think installing via tampermonkey removed this

* Fix alignment on magnet/download images

* Change "Rating" to ⭐
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant