Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue (#298) - System is not generating proper SQL file, compatible w… #299

Merged
merged 1 commit into from
Dec 31, 2018

Conversation

ibrarahmad
Copy link
Contributor

…ith PostgreSQL.

Fixed number of issue with the script.

  • Run SQL file in sequence using serial_schedual file.
  • Handle single/multiple line comments properly.
  • Executing CREATE EXTENSION command, instead of module's SQL files.
  • Miscellaneous small issues.

…mpatible with PostgreSQL.

Fixed number of issue with the script.

- Run SQL file in sequence using serial_schedual file.
- Handle single/multiple line comments properly.
- Executing CREATE EXTENSION command, instead of module's SQL files.
- Miscellaneous small issues.
Copy link
Contributor

@rameshvs02 rameshvs02 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@RoelVdP
Copy link
Contributor

RoelVdP commented Dec 31, 2018

Thank you very much @ibrarahmad, we're merging this now and going to test it soon

@RoelVdP RoelVdP merged commit bd0fd75 into Percona-QA:master Dec 31, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants