Markups planes export #12
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lassoan
reviewed
Dec 23, 2022
mauigna06
force-pushed
the
markupsPlanesExport
branch
from
b2520a7
to
1a46cf9
Compare
ENH: redefine createPlaneModelFromMarkupsPlane
|
@lassoan did I achieve the rebase you wanted? |
lassoan
reviewed
Dec 23, 2022
lassoan
approved these changes
Jan 2, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I did not find a way to not duplicate some code on the
addModelsToRendererfunction because its recursive and I didn't wanted to analyze it too much (but I can do it if required).It works