Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

validation of 'keywords' field is too loose #48

Open
karenetheridge opened this issue Feb 27, 2014 · 1 comment
Open

validation of 'keywords' field is too loose #48

karenetheridge opened this issue Feb 27, 2014 · 1 comment

Comments

@karenetheridge
Copy link
Member

https://metacpan.org/pod/CPAN::Meta::Spec#keywords - "Keywords must not include whitespace." However, CPAN::Meta::Validator only validates the 'keywords' entry as { list => { value => &string } }. 'string' is too lax here.

The other meta validation packages also contain the same issue: Test::CPAN::Meta::Version, Test::CPAN::Meta::YAML::Version, Test::CPAN::Meta::JSON::Version.

Here's an example in the wild that should fail a validation test: https://metacpan.org/source/TOBYINK/Type-Tiny-0.038/META.json#L8

@dagolden
Copy link

Good catch. We should get a fix for that in the validator.

On Thu, Feb 27, 2014 at 6:20 PM, Karen Etheridge
notifications@github.comwrote:

https://metacpan.org/pod/CPAN::Meta::Spec#keywords - "Keywords must not
include whitespace." However, CPAN::Meta::Validator only validates the
'keywords' entry as { list => { value => &string } }. 'string' is too lax
here.

The other meta validation packages also contain the same issue:
Test::CPAN::Meta::Version, Test::CPAN::Meta::YAML::Version,
Test::CPAN::Meta::JSON::Version.

Here's an example in the wild that should fail a validation test:
https://metacpan.org/source/TOBYINK/Type-Tiny-0.038/META.json#L8


Reply to this email directly or view it on GitHubhttps://github.com//issues/48
.

David Golden xdg@xdg.me
Take back your inbox!http://www.bunchmail.com/
Twitter/IRC: @xdg

@karenetheridge karenetheridge self-assigned this Mar 16, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant