porting/cpphdrcheck.t: test perl's headers with C++ compilers #22232
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tonycoz
added
the
defer-next-dev
jkeenan
removed
the
defer-next-dev
|
Is there anyone familiar enough with C++ headers to give this proposal for a porting test a review? IMO it's the sort of thing that, if we're going to pull it into core, we should do so now, at an early point in the current development cycle. |
mauke
reviewed
Jul 16, 2024
Adding _GNU_SOURCE, which was done much later, should give us the
GNU-ish symbols (though POSIX_C_SOURCE would be more general.)
I couldn't find the reason for this being added, but the C++
headers react badly to it:
In file included from /usr/lib/gcc/x86_64-pc-cygwin/11/include/c++/iostream:38,
from source.cpp:1:
/usr/lib/gcc/x86_64-pc-cygwin/11/include/c++/x86_64-pc-cygwin/bits/c++config.h:573:2: warning: #warning "__STRICT_ANSI__ seems to have been undefined; this is not supported" [-Wcpp]
573 | #warning "__STRICT_ANSI__ seems to have been undefined; this is not supported"
| ^~~~~~~
In file included from /usr/lib/gcc/x86_64-pc-cygwin/11/include/c++/bits/max_size_type.h:37,
from /usr/lib/gcc/x86_64-pc-cygwin/11/include/c++/bits/ranges_base.h:38,
from /usr/lib/gcc/x86_64-pc-cygwin/11/include/c++/string_view:48,
from /usr/lib/gcc/x86_64-pc-cygwin/11/include/c++/bits/basic_string.h:48,
from /usr/lib/gcc/x86_64-pc-cygwin/11/include/c++/string:55,
from /usr/lib/gcc/x86_64-pc-cygwin/11/include/c++/bits/locale_classes.h:40,
from /usr/lib/gcc/x86_64-pc-cygwin/11/include/c++/bits/ios_base.h:41,
from /usr/lib/gcc/x86_64-pc-cygwin/11/include/c++/ios:42,
from /usr/lib/gcc/x86_64-pc-cygwin/11/include/c++/ostream:38,
from /usr/lib/gcc/x86_64-pc-cygwin/11/include/c++/iostream:39,
from source.cpp:1:
/usr/lib/gcc/x86_64-pc-cygwin/11/include/c++/numbers:139:9: error: unable to find numeric literal operator 'operator""Q'
139 | = 2.718281828459045235360287471352662498Q;
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
...
This searches for a C++ compiler based on the supplied C compiler, and checks that compiler for any options controlling the C++ standard requested, including simple checks that the compiler supports that standard. If a C++ compiler is found, test compilation of the same simple code as above but with the perl headers included after any C++ headers. Ideally we'd also test runtime, but would require more complex test code, which I leave to later contributors (which may still be me). Tested at various times with: - MSVC - gcc - clang - Oracle/Sun Development Workshop cc (CC is the C++ compiler), on Oracle Linux - Intel oneAPI compiler (llvm based apparently, and now free to use) - Intel classic compiler (discontinued) Currently this probes the compiler for C++ sanity with the perl ccflags, since icc (Intel classic) would successfully build the sample without perl's ccflags, but then fail with both the headers and perl's ccflags. It turned out to fail with just the ccflags, and since the primary intent is to test the headers, I probe *with* ccflags. The Sun Workshop compiler failed to build the C++11 or 14 sample at all in my testing, which may have been due to an installation problem.
tonycoz
force-pushed
the
c++-header-porting
branch
from
ac23c4f
to
2d61a8e
Compare
|
Fixed everything I think:
|
mauke
approved these changes
Jul 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This searches for a C++ compiler based on the supplied C compiler, and
checks that compiler for any options controlling the C++ standard
requested, including simple checks that the compiler supports that
standard.
If a C++ compiler is found, test compilation of the same simple code
as above but with the perl headers included after any C++ headers.
Ideally we'd also test runtime, but would require more complex test
code, which I leave to later contributors (which may still be me).
Tested at various times with:
Currently this probes the compiler for C++ sanity with the perl
ccflags, since icc (Intel classic) would successfully build the sample
without perl's ccflags, but then fail with both the headers and perl's
ccflags. It turned out to fail with just the ccflags, and since the
primary intent is to test the headers, I probe with ccflags.
The Sun Workshop compiler failed to build the C++11 or 14 sample at
all in my testing, which may have been due to an installation problem.
This branch also removes an option added to ccflags by the cygwin hints
that prevented C++ code from compiling.