forcibly check the timing of the regex/alarm test in bulk #18149
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Sep 18, 2020
|
@lightsey ping |
|
Thank you for producing this PR. Making it a TODO is a good idea, in my opinion. I'm 👍'ing this if @lightsey approves it. |
wchristian
force-pushed
the
mithaldu/cygwin_github_smoke_vm_regex_alarm_todo
branch
from
d550035
to
b562821
Compare
hvds
reviewed
Oct 3, 2020
wchristian
force-pushed
the
mithaldu/cygwin_github_smoke_vm_regex_alarm_todo
branch
from
b562821
to
3fe70e6
Compare
|
Pushed an update to address @hvds' comments. |
|
The "increased the multipliers" message doesn't seem true, maybe it's vestigial from a previous iteration? Other than that, LGTM. |
|
Thanks, and yeah, the grammar was wrong, it should say "increase" and refers to the 1000s in the regex. :) |
As per github Perl#18129, github test VMs occasionally fail this alarm test. This commit implements a loop that forces those systems to always fail the test. On cygwin running directly on iron this doesn't fail even after 1000 iterations. However in order to make github smokes a little more useful for now, this also marks it TODO.
wchristian
force-pushed
the
mithaldu/cygwin_github_smoke_vm_regex_alarm_todo
branch
from
3fe70e6
to
dbd559f
Compare
wchristian
deleted the
mithaldu/cygwin_github_smoke_vm_regex_alarm_todo
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As per github #18129, github test VMs occasionally fail this alarm test.
This commit implements a loop that forces those systems to always fail the test.
On cygwin running directly on iron this doesn't fail even after 1000 iterations.
However in order to make github smokes a little more useful for now, this also marks it TODO.