Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mark __CLASS__ as experimental #22387

Merged
merged 1 commit into from
Jul 11, 2024
Merged

Mark __CLASS__ as experimental #22387

merged 1 commit into from
Jul 11, 2024

Conversation

rwp0
Copy link
Contributor

@rwp0 rwp0 commented Jul 9, 2024

Fixes #22288

@leonerd please consider reviewing this if you can

@rwp0
Copy link
Contributor Author

rwp0 commented Jul 9, 2024

I guess I should also add an entry (to document the new warning) in perldiag.pod as with ADJUST for instance?

@rwp0
Copy link
Contributor Author

rwp0 commented Jul 9, 2024

Feedback:
Would like to create/use a label to group all class related PR's together:
image

@rwp0
Copy link
Contributor Author

rwp0 commented Jul 9, 2024

# Failed test 1939 - __CLASS__ is experimental at porting/diag.t line 567
#     Message '__CLASS__ is experimental'
#     from toke.c line 8007 is not listed in pod/perldiag.pod
porting/diag.t ............ 
Failed 1/2[30](https://github.com/Perl/perl5/actions/runs/9864703324/job/27240172900?pr=22387#step:12:31)2 subtests

OK, hello diag.t:

      } else {
        # No listing found, and no excuse either.
        # Find the correct place in perldiag.pod, and add a stanza beginning =item $name.
        fail($name);
        diag("    Message '$name'\n    from $codefn line $. is not listed in $pod");
      }

🙂

@jkeenan jkeenan added the class Issues related to 'class' keyword or __CLASS__ label Jul 9, 2024
@leonerd
Copy link
Contributor

leonerd commented Jul 10, 2024

LGTM

@tonycoz tonycoz merged commit e3d27be into Perl:blead Jul 11, 2024
29 checks passed
@rwp0 rwp0 deleted the patch-12 branch July 11, 2024 10:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
class Issues related to 'class' keyword or __CLASS__
Projects
None yet
Development

Successfully merging this pull request may close these issues.

__CLASS__ doesn't issue an experimental warning
4 participants