Skip to content

Commit a5741f5

Browse files
committed
Fix t/54taint.t failures on perl-in-hell-in-space
Given its a core bug, and the test is not critical, just skip the whole thing
1 parent cebc0cc commit a5741f5

File tree

2 files changed

+7
-0
lines changed

2 files changed

+7
-0
lines changed

Changes

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -13,6 +13,8 @@ Revision history for DBIx::Class
1313
- Fix hang in t/72pg.t when run against DBD::Pg 3.5.0. The ping()
1414
implementation changes due to RT#100648 made an alarm() based
1515
timeout lock-prone.
16+
- Fix failures of t/54taint.t on Windows with spaces in the $^X
17+
executable path (RT#101615)
1618

1719
* Misc
1820
- Remove warning about potential side effects of RT#79576 (scheduled)

t/54taint.t

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -6,6 +6,11 @@ use Config;
66
# doesn't work. We don't want to have the user deal with that.
77
BEGIN { unless ($INC{'t/lib/DBICTest/WithTaint.pm'}) {
88

9+
if ( $^O eq 'MSWin32' and $^X =~ /\x20/ ) {
10+
print "1..0 # SKIP Running this test on Windows with spaces within the perl executable path (\$^X) is not possible due to https://rt.perl.org/Ticket/Display.html?id=123907\n";
11+
exit 0;
12+
}
13+
914
# it is possible the test itself is initially invoked in taint mode
1015
# and with relative paths *and* with a relative $^X and some other
1116
# craziness... in short: just be proactive

0 commit comments

Comments
 (0)