Skip to content
This repository has been archived by the owner on Jun 9, 2023. It is now read-only.

Enhancements + New ToC + New Content #49

Merged
merged 137 commits into from
Jan 17, 2022
Merged

Enhancements + New ToC + New Content #49

merged 137 commits into from
Jan 17, 2022

Conversation

hauni97
Copy link
Contributor

@hauni97 hauni97 commented Dec 9, 2021

Minor improvements.

@netlify
Copy link

netlify bot commented Dec 9, 2021

✔️ Deploy Preview for phala-wiki-preview ready!

🔨 Explore the source changes: ce9ec6d

🔍 Inspect the deploy log: https://app.netlify.com/sites/phala-wiki-preview/deploys/61e57e2b160c3f0007ebbbd2

😎 Browse the preview: https://deploy-preview-49--phala-wiki-preview.netlify.app

@hauni97 hauni97 changed the title Enhancements Developer Section Enhancements Dec 14, 2021
@hauni97
Copy link
Contributor Author

hauni97 commented Dec 15, 2021

Only thing missing is a search-bar in the getting started section. @limichange if you wish to help.

@hauni97
Copy link
Contributor Author

hauni97 commented Jan 12, 2022

Changes in Wiki

Preview 👉 https://deploy-preview-49--phala-wiki-preview.netlify.app/en-us/learn/products/about-pdiem

Some of the new improvements:

  • New sections & separate pages for General, Learn, Build, Maintain and Getting Started. As they are on separate pages, each required new HTML sections for the layout & sidebar: 50f4091 ced36eb 314bc91 e716f55 6f03605 a64b50a & more...

  • Expandable Menu for mobile devices added via HTML headers: 7b2f364

  • Main & 404 error was switched to General -> Learn: e716f55

  • Browser Extension Guide under General -> Phala Wallet has new content (explaining intro paragraph as desired by @shelvenzhou): a9e6b1a

    • Improved readability by scaling the images & adjusting headings, as well as grammar: cfcbb74
  • Gatekeeper under learn -> Maintain, was added with new content (intro paragraph) and remaining information was rewritten (content is subject to review to determine if it is up to date): cc3a3f5

  • Phala Blockchain in Detail -> Learn: Renamed headings & added content to emphasise @shelvenzhou's points: f2f31c6

  • New Fat Contract Content in Learn: https://deploy-preview-49--phala-wiki-preview.netlify.app/en-us/learn/developer/fat-contract/

  • New Fat Contract Content in Build: 435e158

  • Content improvement for /en-us/general/phala-wallet/set-up-identity/: 60b6011

  • This PR contains a brand new "Getting Started" section. Latest commit: a09bd7e

  • Plenty of additional edits & improvements in Mining & Staking: 100+ commits in total

Issues (3)

  • Missing "Search Bar", not global; it is page agnostic (currently only works in “maintain”)

  • Maintain -> Gatekeeper: section is not expanding and showing its articles (not solved yet)

  • Buttons for next page (at the bottom of each article) are not working as intended. Reported here: docs-navigation buttons in PR #49 #60

  • Hypothesis of related files:

    {{ with $pages.Prev . -}}
    <a class="btn-next" href="{{ .RelPermalink }}">
    <div style="margin-right: 18px">
    {{ .Title }}
    </div>
    <svg width="12" height="20" viewBox="0 0 12 20" fill="currentColor" xmlns="http://www.w3.org/2000/svg">
    <path d="M10.1273 8.47763L10.124 8.4809L1.53932 -2.69143e-07L2.65894e-07 1.52074L8.58467 10.0016L0.00331328 18.4793L1.54266 20L10.124 11.5224L11.6633 10.0016L11.6667 9.99836L10.1273 8.47763Z" />
    </svg>
    </a>
    {{ end -}}
    </div>
    {{ end -}}

    .docs-navigation {
    border-top: 1px solid $gray-200;
    margin-top: 2rem;
    margin-bottom: 0;
    padding-top: 2rem;
    }
    .docs-navigation a {
    font-size: $font-size-base * 0.9;
    }
    @include media-breakpoint-up(lg) {
    .docs-navigation {
    margin-bottom: -1rem;
    }
    .docs-navigation a {
    font-size: $font-size-base;
    }
    }

TODO

  • Blockchain Entities: + Video Tutorial: share resources | @HashWarlock I would appreciate you sharing the links.
  • + Getting Started -> Stake Phala image of brokers missing (should be added) + content
  • Wallet Identity: /en-us/general/phala-wallet/set-up-identity/ cosmetics (resize images for conciseness)
  • Add Scores of miners under Tokenomics (from Server) -> Xeon was added: 1591153
  • Cleanup of: 3.0 Console.md: /en-us/docs/khala-mining/3-0-console/ here: 90fcbba
  • General content check of all pages (is it up to date?) @shelvenzhou please let me know
  • Check the issues mentioned above in this comment prior to merging
  • Merge PR: Publish new wiki 🎉
  • Check where links need to be updated (Discord etc.)

@h4x3rotab @shelvenzhou please review the current status

@hauni97 hauni97 mentioned this pull request Jan 13, 2022
4 tasks
@hauni97 hauni97 changed the title Enhancements Enhancements + New ToC + New Content Jan 13, 2022
Copy link
Contributor

@shelvenzhou shelvenzhou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@shelvenzhou shelvenzhou merged commit 8b31aae into master Jan 17, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants