Dev #46
Merged
Dev #46
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
In what timeframe would you need me to review this pull request? |
|
You don't have to review it. It would be nice to get some feedback on how to handle this problem properly. But I'll ask @dsavoiu tomorrow. |
|
This should all be working now. |
cverstege
requested review from
dsavoiu and
JohannesGaessler
and removed request for
dsavoiu and
JohannesGaessler
Update param model on data change for xy fit
after testing update on data change
Rewrite of how data setters in fit classes are handled
dsavoiu
approved these changes
Oct 6, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes updating the data of fit objects.
This needs more work and some help would be appreciated.
Updating the data with a different shape and performing a fit works for: