Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enum support #8

Merged
merged 5 commits into from
Mar 4, 2023
Merged

Enum support #8

merged 5 commits into from
Mar 4, 2023

Conversation

ire4ever1190
Copy link
Contributor

Enums are basically just fancy numbers and so conversion into the database will almost always be the same and so it makes sense to have support for them upstream in lowdb itself

PhilippMDoerner
PhilippMDoerner approved these changes Mar 4, 2023
View reviewed changes
Copy link
Owner

@PhilippMDoerner PhilippMDoerner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The tests and your code are fine.
What this shows me the most is that I should be doing a general sweep over the test-suite.
I personally do not find it obvious what an individual test is supposed to guarantee me, I'll have to go over these test descriptions in bulk in the future.

@PhilippMDoerner
Copy link
Owner

PhilippMDoerner commented Mar 4, 2023 •
edited
Loading

I have come to the realization that this project does not actually have a devel branch!
Apologies for that!
Could you change the PR or reopen it to point to the devel branch I just created and add a note about the change to changelog.md?

Just in case you're wondering why: Now that lowdb is released I'd like to keep the master branch "stable" and only update it in chunks whenever I want to release a new version. Previously it hadn't been released yet.

@ire4ever1190 ire4ever1190 changed the base branch from master to devel March 4, 2023 07:38
@ire4ever1190
Copy link
Contributor Author

Rebased on devel and switched PR to merge into there.

Added changelog entry, not too sure if I got the format right though

PhilippMDoerner
PhilippMDoerner reviewed Mar 4, 2023
View reviewed changes
changelog.md Outdated Show resolved Hide resolved
@PhilippMDoerner PhilippMDoerner merged commit 32a6d83 into PhilippMDoerner:devel Mar 4, 2023
@ire4ever1190 ire4ever1190 deleted the enum-support branch March 4, 2023 08:07
@PhilippMDoerner PhilippMDoerner mentioned this pull request Mar 4, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PhilippMDoerner PhilippMDoerner PhilippMDoerner approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ire4ever1190 @PhilippMDoerner