-
Notifications
You must be signed in to change notification settings - Fork 335
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement Linux support #347
base: master
Are you sure you want to change the base?
Conversation
This branch isn't 100% there, but probably a good time for a review! @remonh87 Some issues I encountered:
|
This builds on the old PR #245 pre-federation. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@robert-ancell Thanks for this PR!! I really like the fact that the native platform support is in a separate plugin because we lack the knowledge about the linux BLE stack. That said it made me think about some things:
- How are we going to do the maintenance and release of the plugin? I can see two approaches:
- we go for this approach and make you contributor to this repo and make it official part of the repo or..
- The advantage of the federated structure is that you can keep full control of the linux plugin and we treat it as an non endorsed plugin. Which we will fully promote and add our example app and docs.
Let me know what you prefer.
I set the pr to request changes because:
- it is not finished (see previous comment)
- Need to fix CI
- Add the BSD license to the package
- Add some docs about how to run it on linux and reference to the BlueZ plugin.
Our preference is option 1 - keep the plugin in the flutter_reactive_ble repository, thanks! |
fab74e4
to
44d78d2
Compare
340a310
to
9dcef30
Compare
9dcef30
to
b30f12d
Compare
Now builds in CI, licensing updated. Outstanding:
|
Great progress awesome! About the docs: I was thinking if there were some specific instructions needed to run it besides starting the app on your linux machine. If there aren't then no need to add it :) |
I'm able to run the example app provided, however i seem to be having issues running it in my own application that already uses flutter_reactive_ble. I seem to be seeing the errors:
when starting to scan for devices. |
@MoralCode It works fine for me on desktop and device. Does it work in debug, or issue is limted to AOT? @remonh87 is this going to get merged? What's the holdup? |
I was most likely running it in debug mode when i posted my previous comments. I dont remember there being a difference between running via hot reload (which i assume is what you mean by AOT) vs doing a full build and run. I'm in the process of polishing the code up and making it open source, so I'll likely be working on a branch with my actual code sometime soon. |
#246