Implement MacOS support using sharedDarwinSource #801
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@rohitsangwan01 did you test all functionally in macos? |
|
@Taym95 i tried basic tasks like connect, disconnect and some services related tasks, but not in detail, and because macos apis are exactly similar to IOS, so both should behave similar in functionality |
I tried this in the past, and not all API worked, please test other functionalities |
|
@Taym95 ok sure, will test all functionalities |
|
any update on this ?? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implemented MacOS support with same Swift code, using SharedDarwinSource
We can use darwin folder instead of ios or macos and keep the single codebase for both Apple platforms, so this way i guess maintenance efforts would be same