Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Assign Super Weapon cameo to any sidebar tab #1387

Merged

Conversation

NetsuNegi
Copy link
Contributor

  • Now you can specific sw will insert to which tab of sidebar.

In rulesmd.ini

[SOMESW]                    ; Super Weapon
TabIndex=1                  ; integer

Copy link

github-actions bot commented Sep 19, 2024

Nightly build for this pull request:

This comment is automatic and is meant to allow guests to get latest nightly builds for this pull request without registering. It is updated on every successful build.

@mevitar
Copy link

mevitar commented Sep 20, 2024

Is it just me, or does the sidebar icon blinks for ready SWs only when they are on structure and defense tabs?
Does it work for infantry/unit tabs for anyone else, or is there some limitation there?

@NetsuNegi
Copy link
Contributor Author

Is it just me, or does the sidebar icon blinks for ready SWs only when they are on structure and defense tabs?
Does it work for infantry/unit tabs for anyone else, or is there some limitation there?

got it, I'll try to fix it

@NetsuNegi
Copy link
Contributor Author

Is it just me, or does the sidebar icon blinks for ready SWs only when they are on structure and defense tabs?
Does it work for infantry/unit tabs for anyone else, or is there some limitation there?

thank you for your feedback

@NetsuNegi
Copy link
Contributor Author

Is it just me, or does the sidebar icon blinks for ready SWs only when they are on structure and defense tabs?
Does it work for infantry/unit tabs for anyone else, or is there some limitation there?

it should be fixed now, could you test it again?

@mevitar
Copy link

mevitar commented Sep 21, 2024

Works fine for all 4 sidebar icons now.

Copy link
Member

@MortonPL MortonPL left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, but I think that we shouldn't take raw user input in cases where it can be easily validated and fixed.

docs/Whats-New.md Outdated Show resolved Hide resolved
CREDITS.md Outdated Show resolved Hide resolved
docs/New-or-Enhanced-Logics.md Outdated Show resolved Hide resolved
src/Ext/SWType/Body.cpp Show resolved Hide resolved
@NetsuNegi NetsuNegi changed the title Customize SuperWeapon TabIndex Assign Super Weapon cameo to any sidebar tab Sep 23, 2024
docs/New-or-Enhanced-Logics.md Outdated Show resolved Hide resolved
@Metadorius Metadorius merged commit fca5e1f into Phobos-developers:develop Sep 23, 2024
4 of 6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants