Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

If session can not be opened, destroy first #66

Closed
g105b opened this issue Apr 10, 2020 · 0 comments · Fixed by #67
Closed

If session can not be opened, destroy first #66

g105b opened this issue Apr 10, 2020 · 0 comments · Fixed by #67

Comments

@g105b
Copy link
Member

g105b commented Apr 10, 2020

In the improbable (but possible) event that a session is corrupted (think load balanced app after being upgraded to new release), the session may not start without issuing a warning. This is fine, because if a session can't start, we should just destroy it and start again, but we need to handle this edge case.
g105b added a commit that referenced this issue Apr 10, 2020
@g105b
Implement session destruction when failure to start
2ae49d0 
Closes #66
@g105b g105b mentioned this issue Apr 10, 2020
Merged
@g105b g105b closed this as completed in #67 Apr 10, 2020
g105b added a commit that referenced this issue Apr 10, 2020
@g105b
If session can not be opened, destroy first (#67)
512f10d 
* Correct typehint, closes #45

* Implement session destruction when failure to start
Closes #66
g105b added a commit that referenced this issue Feb 2, 2023
@g105b
Allow only one failed start_session attempt (#73)
954cc13 
* Correct typehint, closes #45

* Implement session destruction when failure to start
Closes #66

* Simplify destroying failed session

* Allow only 1 failed start of session

* fix: off by one error - caught by phpstan
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

If session can not be opened, destroy first PhpGt/Session
1 participant
@g105b