Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

upgrade pipot from python2 to python3 #30

Merged
merged 1 commit into from
Jul 21, 2019

Conversation

VertexC
Copy link
Contributor

@VertexC VertexC commented Jul 21, 2019

The change has passed both 2.7 and 3.6 test on travis. As python Enum right now is directly acceptable by the SQLAlchemy Enum type as of SQLAlchemy 1.1, the DeclEnum is removed.

@codecov
Copy link

codecov bot commented Jul 21, 2019

Codecov Report

Merging #30 into master will decrease coverage by 0.68%.
The diff coverage is 90%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #30      +/-   ##
==========================================
- Coverage    45.4%   44.72%   -0.69%     
==========================================
  Files          23       23              
  Lines        1775     1726      -49     
==========================================
- Hits          806      772      -34     
+ Misses        969      954      -15
Impacted Files Coverage Δ
database.py 94.44% <ø> (+17.63%) ⬆️
mod_config/controllers.py 35.9% <0%> (ø) ⬆️
config_parser.py 22.22% <0%> (ø) ⬆️
mod_config/models.py 77.14% <100%> (+0.33%) ⬆️
mod_honeypot/controllers.py 22.06% <100%> (ø) ⬆️
mod_honeypot/models.py 62.37% <100%> (+0.37%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9532138...5f03aa2. Read the comment docs.

@canihavesomecoffee canihavesomecoffee merged commit 57cb657 into PiPot:master Jul 21, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants