-
Notifications
You must be signed in to change notification settings - Fork 84
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Inverted text #105
Inverted text #105
Conversation
This should allow white text on a black background, if the "invert" parameter is set to True. Also updated WriteAll() to allow partial or full updates on the PaPiRus screen. Partial updates for text being a lot quicker than a full one.
Added a third Positional Text example with the inverted text option being used
Awesome! That's amazing. I wonder, if in future we could extend it to do inversion for pictures too...? But not relevant for time being. We will test and merge this later in the week :-) |
Hi Ben, thanks, I'll have a look ASAP. Just a consideration though. You are going for partial update by default but I am not sure it might be "frustration free" for beginners. Don't you think the logic should be reversed? |
Probably a good idea, keeps the same functionality as it is currently with the ability to switch to partial updates as needed. I'll make the change. |
Made so that partial updates can be called singly or setting "partial_update" on the instantiated class will make all "WriteAll()" calls be partial updates. The whole class defaults to full updates.
Updated README.md with information about partial updates and how to activate them.
There we go, added some notes to the README.md as well, this time, without messing it up ;) |
All good from my point of view. Could you just amend the papirus-write to add this new option? |
Sorry @francesco-vannini I totally missed this! I can add the option to papirus-write. |
No worries @BenScarb do what you can and we'll try to work around that. Thanks |
Hey @BenScarb , any chance you could look into what we discussed? |
Right. merge conflicts sorted (I think, my Pi is playing up, I've done it without actual testing, my apologies) |
Added in the parameter to allow the inverting of text being displayed.
Done. Sorry for taking so long to get this done, holiday in Turkey got in the way ;-) |
Thanks @BenScarb , testing this now. Just so that it's quicker, what are the parts that you have added/changed so that I can go ahead and amend the README before merge. |
Erm! Let me go check... Added "The Positional Text API (example 3)" section If not using the "partial_updates" property, calling "WriteAll(True)" will do the same thing on a one off basis." I think that's all, at least that's what the diffing tool is telling me! |
Yeah, that's what I managed to find myself too. Thanks! |
This will allow white text on a black background, when the invert parameter is set to True when adding text.
Also the WriteAll will now default to a partial update, unless specifically asked to do a full update as it's quicker that was (and looks better!)