Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Python support for generate_parameter_library #110

Merged
merged 51 commits into from
May 15, 2023
Merged

Add Python support for generate_parameter_library #110

merged 51 commits into from
May 15, 2023

Conversation

pac48
Copy link
Collaborator

@pac48 pac48 commented May 15, 2023

This PR adds Python support for generate_parameter_library, which is a feature that has already been requested #98. All existing features should be supported for the generated Python module: including:

  1. integration into the build system (e.g. setup.py)
  2. automatically declaring and updating parameters
  3. automatically declaring and updating runtime parameters
  4. parameter validation
  5. supported validators
  6. handle user-defined validators

I added an example for the generated Python module in minimal_publisher.py.

Note that the Python code does not separate out stack and heap-allocated parameters and is not designed for multi-threading.

pac48 and others added 30 commits July 28, 2022 19:21
@pac48
add size validator
84a0bee
@tylerjw
fixed string example test
773fe6d 
Signed-off-by: Tyler Weaver <tylerjw@gmail.com>
@pac48
Merge branch 'main' of github.com:PickNikRobotics/generate_parameter_…
58e9c82 
…library
@pac48
Merge branch 'main' of github.com:PickNikRobotics/generate_parameter_…
994a52e 
…library

� Conflicts:
�	example/src/main.cpp
�	generate_parameter_library_py/generate_parameter_library_py/main.py
@pac48
Merge branch 'main' of github.com:PickNikRobotics/generate_parameter_…
4b7eff6 
…library
@pac48
Merge branch 'main' of github.com:PickNikRobotics/generate_parameter_…
38f75cc 
…library
@pac48
Merge branch 'main' of github.com:PickNikRobotics/generate_parameter_…
eec25be 
…library
@pac48
Merge branch 'main' of github.com:PickNikRobotics/generate_parameter_…
1bac853 
…library
@tylerjw
Name cpp generator
673b663
@tylerjw
Parse cli args with argparse
206281b 
Signed-off-by: Tyler Weaver <tyler@picknik.ai>
@tylerjw
Stub for rst generator
db6db7c
@tylerjw
Factor out yaml parsing
11d67eb
@pac48
Merge branch 'PickNikRobotics:main' into main
cccfd56
@pac48
Merge branch 'generate_docs' of https://github.com/PickNikRobotics/ge…
9bf1134 
…nerate_parameter_library into add-generate-parameter-library-python-module
@pac48
refactor parsing code into parse_yaml.py
3c8638b
@pac48
remove parameter_conversion from init functions
9ae57b5
@pac48
add template for declare varible
22ed5c5
@pac48
add python templates and seperate c++ logic to own module
65b7f1c
@pac48
generating python structure almost correct
76f3c69
@pac48
add generate_parameter_module to cmake. Preparing to install module f…
822634e 
…or use with ros2
@pac48
add python example
96ec799
@pac48
module gets install and basic import works
e577c6f
@pac48
declare params working minus dynamic map
369041b
@pac48
working parameter update!
2a134c1
@pac48
update example node
6feba73
@pac48
add TODOs
c7d043a
@pac48
use consistent naming and refactor setup_helper.generate_parameter_mo…
ddbade8 
…dule
@pac48
fix example node name and declare_params to load yaml params correctly
2fd4cb3
@pac48
add python templates to setup.py install
d7a3b32
@pac48
fix colcon build without symlink install
9ced69b
pac48 and others added 21 commits May 3, 2023 10:45
@pac48
add license and description
e63741d
@pac48
begin implementation of custom validation
21e2b1e
@pac48
add convertions for valdiation functions
b97fb7f
@pac48
disable validations for now
ac16520
@pac48
validation working with mock functions
db79b1d
@pac48
run pre-commit
13e570e
@pac48
update test
96d8f75
@pac48
make validation_module optional
f40ac57
@pac48
add declare runtime parameters
852a1af
@pac48
add runtime parameters
6b5c792
@pac48
add implementation to validations
8399ae1
@pac48
update example README and python example node
ea34651
@pac48
use attributes instead of dictionary
7ba16ac
@pac48
update README and license
0419206
@pac48
clean up diff
25dfa24
@pac48
run precommit
6eaed56
@pac48
fix name of generate_parameter_library binary in cmake
65d4a67
@pac48
fix function_base_name
9a683b4
@pac48
remove cpp naming from parse yaml code
b611d11
@pac48
use add refresh_dynamic_parameters and fix floating_point_range and i…
1e64921 
…nteger_range validations
@pac48
code clean up
d820c36
tylerjw
tylerjw approved these changes May 15, 2023
View reviewed changes
Copy link
Contributor

@tylerjw tylerjw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉 thank you for this! Looking forward to the docs generation PR too.

@tylerjw tylerjw merged commit 95810e6 into PickNikRobotics:main May 15, 2023
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tylerjw tylerjw tylerjw approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@pac48 @tylerjw