Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix deprecation issues, rename func publishMarkersWithoutTrigger() #123

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix deprecation issues, rename func publishMarkersWithoutTrigger() #123

wants to merge 1 commit into from

Conversation

davetcoleman
Copy link
Member

  • Switch to C++14 deprecation approach

@auto-assign auto-assign bot requested a review from tylerjw August 14, 2019 00:02
@davetcoleman davetcoleman mentioned this pull request Aug 14, 2019
Merged
@davetcoleman
Copy link
Member Author

@simonschmeisser this is per your suggestion

@davetcoleman
Copy link
Member Author

@simonschmeisser could you approve please?

simonschmeisser
simonschmeisser approved these changes Aug 21, 2019
View reviewed changes
Copy link
Contributor

@simonschmeisser simonschmeisser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the name could be improved, from an outside point of view you don't expect the caching/triggering to be necessary. So maybe 'actuallyPublishMarkers' or 'directlyPublishMarkers' or 'publishMarkersDirectly'?

Greetings from the Italian alps, this is a smartphone review :)

tylerjw
tylerjw approved these changes Nov 16, 2020
View reviewed changes
Copy link
Contributor

@tylerjw tylerjw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good, should be rebased first before it can be merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@simonschmeisser simonschmeisser simonschmeisser approved these changes

@tylerjw tylerjw tylerjw approved these changes

@mlautman mlautman mlautman approved these changes

Assignees

@tylerjw tylerjw

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@davetcoleman @simonschmeisser @tylerjw @mlautman