Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reduce GitHub Actions build workflow permissions #221

Merged
merged 2 commits into from
Sep 8, 2022
Merged

Reduce GitHub Actions build workflow permissions #221

merged 2 commits into from
Sep 8, 2022

Conversation

Stephan202
Copy link
Member

No description provided.

@rickie
Copy link
Member

rickie commented Sep 5, 2022

The build fails with:

Deleting the contents of '/home/runner/work/error-prone-support/error-prone-support'
Initializing the repository
Disabling automatic garbage collection
Setting up auth
Fetching the repository
  /usr/bin/git -c protocol.version=2 fetch --no-tags --prune --progress --no-recurse-submodules --depth=1 origin +b7b742651428305f2689d8a06cc779a390b5e0c7:refs/remotes/pull/2[21](https://github.com/PicnicSupermarket/error-prone-support/runs/8182622742?check_suite_focus=true#step:2:23)/merge
  remote: Repository not found.
  Error: fatal: repository 'https://github.com/PicnicSupermarket/error-prone-support/' not found
  The process '/usr/bin/git' failed with exit code 128
  Waiting 14 seconds before trying again
  /usr/bin/git -c protocol.version=2 fetch --no-tags --prune --progress --no-recurse-submodules --depth=1 origin +b7b742651428305f2689d8a06cc779a390b5e0c7:refs/remotes/pull/221/merge
  remote: Repository not found.
  Error: fatal: repository 'https://github.com/PicnicSupermarket/error-prone-support/' not found
  The process '/usr/bin/git' failed with exit code 128
  Waiting 12 seconds before trying again
  /usr/bin/git -c protocol.version=2 fetch --no-tags --prune --progress --no-recurse-submodules --depth=1 origin +b7b742651428305f2689d8a06cc779a390b5e0c7:refs/remotes/pull/221/merge
  remote: Repository not found.
  Error: fatal: repository 'https://github.com/PicnicSupermarket/error-prone-support/' not found
  Error: The process '/usr/bin/git' failed with exit code 128

@Stephan202
Copy link
Member Author

Yes, this PR is in draft for that exact reason.

@Stephan202 Stephan202 marked this pull request as ready for review September 5, 2022 13:00
Stephan202
Stephan202 commented Sep 5, 2022
View reviewed changes
Copy link
Member Author

@Stephan202 Stephan202 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Now the build passes. So contents: read is necessary and sufficient.

@Stephan202 Stephan202 added this to the 0.2.1 milestone Sep 5, 2022
rickie
rickie approved these changes Sep 6, 2022
View reviewed changes
Copy link
Member

@rickie rickie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@rickie rickie added the chore A task not related to code (build, formatting, process, ...) label Sep 6, 2022
@rickie
Copy link
Member

rickie commented Sep 6, 2022

Suggested commit message:

Reduce GitHub Actions build workflow permissions (#221)

@rickie rickie requested a review from werli September 7, 2022 13:01
werli
werli approved these changes Sep 8, 2022
View reviewed changes
Copy link
Member

@werli werli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Given my limited knowledge of this: LGTM

@rickie rickie removed the request for review from nathankooij September 8, 2022 06:54
@rickie rickie changed the title Reduce Github Actions build workflow permissions Reduce GitHub Actions build workflow permissions Sep 8, 2022
@rickie rickie merged commit b88a668 into master Sep 8, 2022
@rickie rickie deleted the sschroevers/reduce-gha-build-permissions branch September 8, 2022 06:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@werli werli werli approved these changes

@rickie rickie rickie approved these changes

Assignees
No one assigned
Labels
chore A task not related to code (build, formatting, process, ...)
Milestone
0.3.0
Development

Successfully merging this pull request may close these issues.
3 participants
@Stephan202 @rickie @werli