use pikaday element instead of child element when comparing against trigger element #166
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks @alanhamlett! This was driving me nuts, fix worked! |
rikkert
added a commit
that referenced
this pull request
Dec 16, 2014
use pikaday element instead of child element when comparing against trigger element
radiac
added a commit
to radiac/Pikaday
that referenced
this pull request
Jan 6, 2015
Changes in Pikaday#166 broke the click handler's detection of clicks within the pikaday element; for example, clicking on the date drop-downs, as reported in issues Pikaday#224 and Pikaday#230. This change adds the original conditions to the patch in Pikaday#166. This fixes the introduced bug, while leaving the fixes for child elements in place.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is to fix a bug that occurs when a child element inside the trigger element is clicked. When the child element is clicked, the date picker should still open.