Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support images in EqEx #23

Closed
Nircek opened this issue Feb 2, 2021 · 7 comments
Closed

Support images in EqEx #23

Nircek opened this issue Feb 2, 2021 · 7 comments
Assignees
@Nircek
Milestone
v0.2 - the users

Comments

@Nircek
Copy link
Member

Nircek commented Feb 2, 2021

No description provided.

@Nircek Nircek self-assigned this Feb 2, 2021
@Nircek Nircek added this to the v0.2 - the database prototype milestone Feb 2, 2021
@Nircek Nircek mentioned this issue Feb 4, 2021
Closed
@Marwyk2003
Copy link
Member

Marwyk2003 commented Feb 20, 2021 •
edited
Loading

Images are stored in render's YAML type under content[imgs].
content[imgs] is an array of strings (or an empty array if no images were provided).

@Nircek
Copy link
Member Author

Nircek commented Feb 21, 2021 •
edited
Loading

Images will be stored in a static subfolder of each subject folder. There can be any static content. It can be accessed by /api/public/:subject/static/:file endpoint (#25). We can send it in the EqEx via the img field but shouldn't it be universal for all Exercises?

@Nircek Nircek mentioned this issue Feb 22, 2021
Closed
@Nircek
Copy link
Member Author

Nircek commented Mar 15, 2021

I added images in Pikne-Programy/pikne-zadania-exercises@3486bb3

@Nircek Nircek closed this as completed in f03e887 Mar 16, 2021
@Nircek
Copy link
Member Author

Nircek commented Mar 16, 2021

@miloszwasacz review if it works, please. Feel free to reopen the issue if you have any problems.

@miloszwasacz
Copy link
Member

There seems to be an inconsistency in the EqEx structure. According to API images are in imgs field, but the server sends a JSON with img field.

@miloszwasacz miloszwasacz reopened this Mar 16, 2021
@Nircek
Copy link
Member Author

Nircek commented Mar 16, 2021

I have corrected it. @miloszwasacz, close if there's no problem left.

@miloszwasacz
Copy link
Member

Everything seems fine, closing.

miloszwasacz added a commit that referenced this issue Mar 16, 2021
@miloszwasacz
Update image fetching according to new API (#23)
7c09c16
Nircek added a commit to Pikne-Programy/pikne-zadania-dev that referenced this issue Sep 8, 2021
@Nircek
add a static content request (Pikne-Programy/pikne-zadania#23 (comment))
a53bf7d
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Nircek Nircek

Labels
None yet
Projects
None yet
Milestone
v0.2 - the users
Development

No branches or pull requests
3 participants
@Nircek @Marwyk2003 @miloszwasacz