-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Copyright Notice #57
Conversation
We can update the I know this is very ugly and it contains some meaningless rows (no licensed). I will create a mechanism to format the file in a good style with the script. I'm using a plugin to collect licenses I referred in #40. NOTE: The plugin fails to collect licenses of some libraries such as https://github.com/rejasupotaro/kvs-schema. I'm not sure why (maybe, the LICENSE file should not have any extension?). |
And I found this PR causes an error in Travis because of some tasks introduced by the plugin. Please give this some comments. What do you think about this way to update and show copyrights? |
I don't know but I don't think the copyright notices have to have pretty appearance. Also I can't understand why you introduced the simple shell script. Does it have any advantages against grande scripts? or you couldn't do something in gradle? |
Oh, I think it's better to use gradle :) I'm not so familiar with making gradle scripts but I'll try. Thanks for your comment. I'm thinking of making a placeholder of copyright such as https://gist.github.com/cyrilmottier/4124374, and generating a html by inserting the libraries' information collected by a plugin. |
e2e516c
to
297f271
Compare
I changed my mind to use another plugin to make How to use it for others' licensesFirstly, run
and you'll see some lists of licenses we use if they are lack in
If there is no error, you can get |
While I decided to use the another plugin for others' libraries, I keep the original one for our license. Because it can maintain all the license headers of source files with a command. How to use it for our licenseKeep Run
and this will format all the files. If you want to know all the files follow the
and this will be executed automatically while building our app. NoteI'm not sure why it happens but See the build error;
To avoid this, I set
|
Since the license checks of new plugins will be executed automatically, I had to fix the license headers of files and they may be annoying when you review this PR. I'm sorry for that. |
Ah... one more thing. I had to fix |
Hey @Myusak, Please review this PR. Thank you in advance. |
* add icense-gradle-plugin * add CopyrightNoticeFragment and a simple script (WIP) * update LICENSE and refer it from gradle * update the headers of Java files by using licenseFormat command * refactor .travis.yml and change the android target version * add tasks to clean up licenses * rename license files * replace the plugin to make licenses.html with cookpad's one * remove scripts folder * readd license-gradle-plugin * update xml's licenses * ignore *Test.java for license checking * fix an error on app/src/main/res/layout/activity_setting.xml * fix an error on app/src/main/res/layout/content_execution.xml
This PR solves #40.
This PR introduces ;
licenses.html
)licenses.html
easily