-
Notifications
You must be signed in to change notification settings - Fork 36
Removing _http
passing and getting it from the client
#272
Conversation
Codecov Report
@@ Coverage Diff @@
## main #272 +/- ##
=======================================
Coverage 90.00% 90.00%
=======================================
Files 9 9
Lines 100 100
=======================================
Hits 90 90
Misses 10 10 Continue to review full report at Codecov.
|
I vote for this but it needs to be fixed everywhere that uses _http |
This is the role of the second commit, expect if i missed any other |
Couldn’t you just remove _client.http or would that be harder? |
|
Co-authored-by: trag1c <77130613+trag1c@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
~ Seems fine
See #266