Skip to content
This repository has been archived by the owner on Dec 26, 2022. It is now read-only.

Removing _http passing and getting it from the client #272

Merged
merged 4 commits into from
Dec 1, 2021

Conversation

Sigmanificient
Copy link
Member

See #266

@Sigmanificient Sigmanificient requested review from Arthurdw, Lunarmagpie, Enderchief and trag1c and removed request for Arthurdw November 29, 2021 22:34
@codecov
Copy link

codecov bot commented Nov 29, 2021

Codecov Report

Merging #272 (09a2a42) into main (898c18d) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #272   +/-   ##
=======================================
  Coverage   90.00%   90.00%           
=======================================
  Files           9        9           
  Lines         100      100           
=======================================
  Hits           90       90           
  Misses         10       10           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 898c18d...09a2a42. Read the comment docs.

@Lunarmagpie
Copy link
Member

I vote for this but it needs to be fixed everywhere that uses _http

@Sigmanificient
Copy link
Member Author

I vote for this but it needs to be fixed everywhere that uses _http

This is the role of the second commit, expect if i missed any other

@VincentRPS
Copy link
Contributor

Couldn’t you just remove _client.http or would that be harder?

@Lunarmagpie
Copy link
Member

_client.http is how _http is set in the first place

pincer/objects/guild/guild.py Outdated Show resolved Hide resolved
pincer/objects/guild/member.py Outdated Show resolved Hide resolved
pincer/objects/guild/member.py Outdated Show resolved Hide resolved
pincer/objects/guild/member.py Outdated Show resolved Hide resolved
@Sigmanificient Sigmanificient linked an issue Nov 30, 2021 that may be closed by this pull request
Co-authored-by: trag1c <77130613+trag1c@users.noreply.github.com>
@Arthurdw Arthurdw merged commit 26847c0 into Pincer-org:main Dec 1, 2021
Copy link
Member

@Arthurdw Arthurdw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

~ Seems fine

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

🔥 _client.http is a duplicate of _http ...for every APIObject
6 participants