Skip to content
This repository has been archived by the owner on Dec 26, 2022. It is now read-only.

✨ Adding ScheduleEvent #304

Merged
merged 12 commits into from
Dec 16, 2021
Merged

Conversation

Sigmanificient
Copy link
Member

Changes

  • adds: ScheduleEvent

Check off the following

  • I have tested my changes with the current requirements
  • My Code follows the pep8 code style.

@codecov
Copy link

codecov bot commented Dec 12, 2021

Codecov Report

Merging #304 (b0ae515) into main (b311d76) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #304   +/-   ##
=======================================
  Coverage   90.00%   90.00%           
=======================================
  Files           9        9           
  Lines         100      100           
=======================================
  Hits           90       90           
  Misses         10       10           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b311d76...b0ae515. Read the comment docs.

Copy link
Member

@Lunarmagpie Lunarmagpie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this file should be renamed to scheduled_events.py

pincer/objects/guild/schedule_events.py Outdated Show resolved Hide resolved
pincer/objects/guild/schedule_events.py Outdated Show resolved Hide resolved
pincer/objects/guild/schedule_events.py Outdated Show resolved Hide resolved
pincer/objects/guild/schedule_events.py Outdated Show resolved Hide resolved
pincer/objects/guild/schedule_events.py Outdated Show resolved Hide resolved
Sigmanificient and others added 2 commits December 13, 2021 17:04
Co-authored-by: Izhar Ahmad <54180221+nerdguyahmad@users.noreply.github.com>
pincer/objects/guild/scheduled_events.py Outdated Show resolved Hide resolved
pincer/objects/guild/scheduled_events.py Outdated Show resolved Hide resolved
pincer/objects/guild/guild.py Outdated Show resolved Hide resolved
pincer/objects/guild/scheduled_events.py Outdated Show resolved Hide resolved
Lunarmagpie and others added 7 commits December 15, 2021 15:40
Co-authored-by: trag1c <77130613+trag1c@users.noreply.github.com>
Co-authored-by: trag1c <77130613+trag1c@users.noreply.github.com>
Co-authored-by: trag1c <77130613+trag1c@users.noreply.github.com>
@Lunarmagpie Lunarmagpie merged commit 477871d into Pincer-org:main Dec 16, 2021
@Sigmanificient Sigmanificient deleted the missing-objects branch December 16, 2021 04:24
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants