This repository has been archived by the owner on Dec 26, 2022. It is now read-only.
🐛 Transform message.edit list of APIObject to JSONSerializable
#306
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
drawbu
changed the title
message.edit to transform all APIObject objects into JSON serializable
Codecov Report
@@ Coverage Diff @@
## main #306 +/- ##
=======================================
Coverage 90.00% 90.00%
=======================================
Files 9 9
Lines 100 100
=======================================
Hits 90 90
Misses 10 10 Continue to review full report at Codecov.
|
Sigmanificient
changed the title
message.edit to transform all APIObject objects into JSON serializablemessage.edit list of APIObject to JSONSerializable
Sigmanificient
changed the title
message.edit list of APIObject to JSONSerializablemessage.edit list of APIObject to JSONSerializable
Sigmanificient
suggested changes
Dec 13, 2021
Sigmanificient
suggested changes
Dec 13, 2021
| @@ -49,7 +50,7 @@ class AllowedMentionTypes(str, Enum): | |||
| EVERYONE = "everyone" | |||
|
|
|||
|
|
|||
| @dataclass(repr=False) | |||
| @dataclass | |||
Enderchief
approved these changes
Dec 13, 2021
|
waiting for |
added 2 commits
December 13, 2021 21:11
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
fixed: uses recursion to transform all APIObject objects into JSON serializable, because things like Embed are in list and were not set as json objects like mentionned in Can't edit an Embed message with.edit#305 :/Check off the following