-
Notifications
You must be signed in to change notification settings - Fork 100
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: support env and product dockerfile #2615
Conversation
Signed-off-by: lijie <lijie@pingcap.com>
Review for Pull Request feat: support env and product dockerfileSummaryThis pull request adds support for building Docker images with customized environment variables and product Dockerfiles. Potential ProblemsThere are no major issues with this pull request. However, there are some minor issues that can be fixed:
Fix Suggestions
|
Signed-off-by: lijie <lijie@pingcap.com>
The changes in the pull request aim to add support for customized product images and environment variables during the build process. The changes made include adding new parameters for dockerfile, builder image, and environment variables. Also, a function named 'do_release' is added to support the execution of a command with environment variables. The changes seem to be reasonable and well-documented. However, there are some potential problems that need to be addressed:
Suggestions for fixing these problems:
Overall, the changes made in the pull request are valuable, but some improvements are needed to ensure that they are easy to use and work as intended. |
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: wuhuizuo The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
[LGTM Timeline notifier]Timeline:
|
Add new param for build-common, relate to #2615. Signed-off-by: purelind <purelind@gmail.com>
Why:
How: