fix(types): dedupe unique and greatest strategy needs id #11945
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 2 Ignored Deployments
|
dylburger
added
the
triaged
joscha
commented
May 14, 2024
| @@ -310,15 +310,23 @@ export interface EmitMetadata { | |||
| ts?: number; | |||
There was a problem hiding this comment.
possibly the timestamp is a prerequisite for the greatest strategy. Let me know if that is the case and I can make the change.
joscha
commented
May 14, 2024
joscha
commented
May 14, 2024
|
I seem to be getting: from the spellcheck step (see https://github.com/PipedreamHQ/pipedream/actions/runs/9087144710/job/24974295576). I thought it was because of an outdated Maybe the rebase: is this actual issue? The base commit is nowhere to be found. The repository with the action has not been updated in 4 years. Suggested "fix" is: pushed 70e85af to this PR with the suggested workaround. |
joscha
commented
May 14, 2024
There was a problem hiding this comment.
for #11945 (comment) a possibly better way would be to use a fork of the original unmaintained action in https://github.com/Ana06/get-changed-files - it's a drop in replacement with a fix for the issue and a few other improvements. Let me know if you prefer the fork.
There was a problem hiding this comment.
opened an adjacent pull request in #11949
will rebase this PR on top of it, if it gets merged before and remove the continue-on-error flags.
|
@michelle0927 Can you make a review in this PR too? just for sure |
lcaresia
approved these changes
May 15, 2024
lcaresia
approved these changes
May 15, 2024
michelle0927
approved these changes
May 15, 2024
|
Merge this on behalf of user |
dannyroosevelt
added a commit
that referenced
this pull request
May 24, 2024
* Fixing typo in GH error message (#11816) * Fixing typo in GH error message * Incrementing versions * Bump tqdm from 4.66.1 to 4.66.3 in /blog/pi (#11818) Bumps [tqdm](https://github.com/tqdm/tqdm) from 4.66.1 to 4.66.3. - [Release notes](https://github.com/tqdm/tqdm/releases) - [Commits](tqdm/tqdm@v4.66.1...v4.66.3) --- updated-dependencies: - dependency-name: tqdm dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Bump tqdm from 4.66.1 to 4.66.3 in /packages/component_code_gen (#11819) Bumps [tqdm](https://github.com/tqdm/tqdm) from 4.66.1 to 4.66.3. - [Release notes](https://github.com/tqdm/tqdm/releases) - [Commits](tqdm/tqdm@v4.66.1...v4.66.3) --- updated-dependencies: - dependency-name: tqdm dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Adding HIPAA docs, removing deprecated migration plan (#11729) * New Components - vryno (#11628) * vryno init * [Components] vryno #11624 Actions - Create Unique Lead * pnpm update * remove console.log * some adjusts * New Components - orimon (#11802) * orimon init * [Components] orimon #11796 Actions - Send Message * pnpm update * bug fix (#11812) * New Components - relavate (#11803) * relavate init * new components * pnpm-lock.yaml * fix typo * Telnyx - Ability to retrieve a message (#11710) * Added the ability to list phone numbers * Adjusted component/action versions * eslint * Updated constants file * constants.mjs * version * Added Retrieve Message action * Fixed error message details * versions --------- Co-authored-by: michelle0927 <michellelbergero@hotmail.com> Co-authored-by: michelle0927 <michelle0927@users.noreply.github.com> * Adding newest YT intro video * Reusing Gitlab components for Developer App (#11603) * New app/package * Creating actions reusing Gitlab actions * Package update * pnpm * Mapping propDefinitions to new app * Adjusting actions' propDefinitions * Adjusting sources to use mapped propDefinitions * Removing unused file * Fixing import error for sources * Updating list projects * Gitlab version bumps * package newline * Description update * Making username required * Fix labels and parentId optional * Fixing 'new milstone' * Adjusting 'new review request' * Update issue: fixing labels on request * Replacing node-fetch with axios * Splittin group path and group id * Adding error treatment for source * Bump jinja2 from 3.1.3 to 3.1.4 in /blog/pi (#11825) Bumps [jinja2](https://github.com/pallets/jinja) from 3.1.3 to 3.1.4. - [Release notes](https://github.com/pallets/jinja/releases) - [Changelog](https://github.com/pallets/jinja/blob/main/CHANGES.rst) - [Commits](pallets/jinja@3.1.3...3.1.4) --- updated-dependencies: - dependency-name: jinja2 dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * WooCommerce App Marketplace page (#11826) * Adding troubleshooting and getting started steps * correcting hierarchy * example use case docs * Migrated to latest rest api version (#11707) * Added actions (#11808) * New Components - tripadvisor_content_api (#11403) * tripadvisor_content_api init * Added actons * Update components/tripadvisor_content_api/actions/location-reviews/location-reviews.mjs Co-authored-by: Luan Cazarine <luanhc@gmail.com> * Update components/tripadvisor_content_api/actions/location-search/location-search.mjs Co-authored-by: Luan Cazarine <luanhc@gmail.com> * Update components/tripadvisor_content_api/tripadvisor_content_api.app.mjs Co-authored-by: Luan Cazarine <luanhc@gmail.com> * Update components/tripadvisor_content_api/tripadvisor_content_api.app.mjs Co-authored-by: Luan Cazarine <luanhc@gmail.com> * Update components/tripadvisor_content_api/tripadvisor_content_api.app.mjs Co-authored-by: Luan Cazarine <luanhc@gmail.com> * Update components/tripadvisor_content_api/tripadvisor_content_api.app.mjs Co-authored-by: Luan Cazarine <luanhc@gmail.com> * Bump package.json version * Remove redundant prop * Remove redundant prop * Revert "Remove redundant prop" This reverts commit 80b81c4. * Revert "Remove redundant prop" This reverts commit bca8cf1. * Fixing file name --------- Co-authored-by: Luan Cazarine <luanhc@gmail.com> Co-authored-by: Leo Vu <18277920+vunguyenhung@users.noreply.github.com> Co-authored-by: Leo Vu <vunguyenhung@outlook.com> * Adding app scaffolding for fly_io * Adding mongodb connecting and troubleshooting (#11835) * Tested component with queries (#11828) * Firestore Firebase - parse boolean values in Update Document & Create Document (#11801) * parse boolean values * versions * Remove 0 and 1 case for boolean * Fix typos --------- Co-authored-by: Leo Vu <vunguyenhung@outlook.com> Co-authored-by: Leo Vu <18277920+vunguyenhung@users.noreply.github.com> * Merge branch 'issue-11579' into 9395-action-zoom-app-zoom-phones-get-call-logs-action (#11781) * AWS readme (#11841) * Google Drive Triggers text/usability improvements (#11652) * Description update * Adding descriptions for update types * description adjustment * Adjustments * Text improvements * text update * Reverting specific drive change * Version bumps * Creating common file interval deduping * Applying dedupe changes for file modification sources * Version bumps * Version bumps * Moving constants to common folder * adjusting 'changes' schema * 'Share File' improvements * Sharing file adjustments * Adding advanced role options * Version adjustment * Updating component code to use PD Proxy for requests. (#11842) * Updating component code to use PD Proxy for requests. * Version bump. * Tested components (#11820) * GDrive Component description updates (#11844) * SendGrid readme (#11850) * New Components - bilflo (#11840) * bilflo init * [Components] bilflo #11732 Actions - Create Client - Assign Contract Job To Invoice - Create Contract Job * pnpm update * add datetime format description * New Components - cradl_ai (#11830) * cradl_ai init * new components * pnpm-lock.yaml * Klayvio Readme (#11852) * Zendesk API (#11853) * 9395 action zoom app zoom phones get call logs action (#11854) * Merge branch 'issue-11579' into 9395-action-zoom-app-zoom-phones-get-call-logs-action * bump version * Auto-generated documentation for apps (#11800) * Auto-generated documentation for apps * Overledger (`overledger`) * Chaser (`chaser`) * SARE (`sare`) * Encodian (`encodian`) * ByteNite (`bytenite`) * Sigma (`sigma`) * Thoughtly (`thoughtly`) * Plate Recognizer (`platerecognizer`) * Flipando (`flipando`) * Relavate (`relavate`) * TimeTonic (`timetonic`) * Cradl AI (`cradl_ai`) * Bilflo (`bilflo`) * Navigatr (`navigatr`) * ChatFly (`chatfly`) * Perplexity (`perplexity`) * FracTEL (`fractel`) * y.gy (`y_gy`) * SkyCiv (`skyciv`) * Zip Archive API (`zip_archive_api`) * Connectwise PSA (`connectwise_psa`) * Botpress (`botpress`) * Orimon (`orimon`) * Soax (`scrapein_`) * Twenty (`twenty`) * Delete components/bytenite/README.md hallucination * Delete components/flipando/README.md * Delete components/navigatr/README.md * Delete components/orimon/README.md * Delete components/thoughtly/README.md incorrect * Delete components/twenty/README.md --------- Co-authored-by: Pipedream Component Development <106282845+pipedream-component-development@users.noreply.github.com> Co-authored-by: Michael Lim <42158621+malexanderlim@users.noreply.github.com> * ESLint PR check improvement (#11846) * adding eslintignore extensions * Adding quiet to suppress non-error warnings * New Components - timetonic (#11813) * timetonic init * new components * pnpm-lock.yaml * handle link fields * upload files * parse boolean values * versions & form-data dependency * pnpm-lock.yaml * updates * Slack readme * Component republishes (#11898) * Google Sheets version bumps * Google Drive & Gitlab Dev App bumps * Zoom Admin version bumps * Google sheets import fix * Auto-generated documentation for apps (#11897) * Auto-generated documentation for apps * Fly.io (`fly_io`) * Flipando (`flipando`) * Orimon (`orimon`) * Delete components/orimon/README.md * Delete components/flipando/README.md --------- Co-authored-by: Pipedream Component Development <106282845+pipedream-component-development@users.noreply.github.com> Co-authored-by: Michael Lim <42158621+malexanderlim@users.noreply.github.com> * Updating Perplexity to latest models. (#11904) * Updating Perplexity to latest models. * Updating constants. * Updating package. * Adding app scaffolding for pro_ledger * Adding app scaffolding for wiza * Adding app scaffolding for summit * Adding app scaffolding for leadiq * docs: add tap info for brew installation (#11895) Without tapping it first you get the following error: ``` Warning: 'pipedreamhq/pd-cli/pipedream' formula is unreadable: No available formula with the name "pipedreamhq/pd-cli/pipedream". Please tap it and then try again: brew tap pipedreamhq/pd-cli ``` * Hubspot - New Event source (#11855) * update description * add configuration error * Google Sheet Sources/Triggers Improvements (#11711) * add test events * move constants.mjs to common folder * update deduping to support longer ids * update versions * combine shared & non-shared drive sources * new-comment source * add new-comment test-event * versions * versions * Google Sheets Actions Improvements (#11782) * add doc links * replace sheetName w/ worksheetId, ConfigurationErrors, updates * use alert prop for rows description * combine find-row & find-row-vlookup * combine delete-row & delete-rows * versions * fix version * bump package version * parse array inputs * combine get-values & get-values-in-range * update action names * headersDisplay prop * update cells description * update clear-row to clear-rows * versions * versions * [Components] Hotmart #8023 (#11626) * Added actions * Fixed requested changes * Fixed requested changes * Adding app scaffolding for pitchlane * Adding app scaffolding for appwrite * Bump actions/checkout from 4.1.4 to 4.1.5 (#11928) Bumps [actions/checkout](https://github.com/actions/checkout) from 4.1.4 to 4.1.5. - [Release notes](https://github.com/actions/checkout/releases) - [Changelog](https://github.com/actions/checkout/blob/main/CHANGELOG.md) - [Commits](actions/checkout@v4.1.4...v4.1.5) --- updated-dependencies: - dependency-name: actions/checkout dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Bump pnpm/action-setup from 3.0.0 to 4.0.0 (#11929) Bumps [pnpm/action-setup](https://github.com/pnpm/action-setup) from 3.0.0 to 4.0.0. - [Release notes](https://github.com/pnpm/action-setup/releases) - [Commits](pnpm/action-setup@v3.0.0...v4.0.0) --- updated-dependencies: - dependency-name: pnpm/action-setup dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * New Components - twenty (#11823) * twenty init * [Components] twenty #11736 Sources - New Record (Instant) Actions - Create Update Delete Record * pnpm update * some adjusts * some adjusts * Adding app scaffolding for pidj * Adding app scaffolding for keycloak * Adding app scaffolding for insighto_ai * Adding app scaffolding for kodagpt * HIPAA on Enterprise (#11941) * Update eslintignore to ignore *.mdx (#11948) * [ACTION] Unsplash - Search Photos, Get Photo (#11939) * Tested components * pnpm-lock.yaml * Added tested components (#11845) * Tested components (#11893) * Adding app scaffolding for boloforms * New Components - chatfly (#11931) * chatfly init * [Components] chatfly #11730 Actions - SendMessage * pnpm update * Update components/chatfly/chatfly.app.mjs * fix description --------- Co-authored-by: Leo Vu <18277920+vunguyenhung@users.noreply.github.com> * New Components - thoughtly (#11933) * thoughtly init * [Components] thoughtly #11728 Sources - New Response (Instant) Actions - Trigger Call - Create Contact * pnpm update * fix import * add doc links --------- Co-authored-by: michelle0927 <michellelbergero@hotmail.com> * Adding app partners page to docs and fixing some typos. (#11947) * Adding app partners page to docs and fixing some typos. * Update docs-v2/pages/apps/app-partners.mdx Co-authored-by: Danny Roosevelt <danny@pipedream.com> * Update docs-v2/pages/apps/app-partners.mdx Co-authored-by: Danny Roosevelt <danny@pipedream.com> --------- Co-authored-by: Danny Roosevelt <danny@pipedream.com> * Adding app scaffolding for upstash_redis * chore: replace unmaintained jitterbit/get-changed-files@v1 (#11949) * [Components] leadiq (#11923) * Tested component * pnpm-lock.yaml * fix(types): dedupe unique and greatest strategy needs id (#11945) * Added actions (#11951) * New Components - fractel (#11807) * fractel init * [Components] fractel #11791 Actions - Call Phone - Send SMS/MMS * pnpm update * some adjusts * New Components - platerecognizer (#11944) * platerecognizer init * [Components] platerecognizer #11727 Actions - Run Recognition * pnpm update * [Docs] Data stores atomic operations (#11961) * add section for data stores atomic operations * link to integrated apps * chore: remove temporary continue-on-error fix for changed files (#11959) * Tested components (#11958) * [BUG] Postmark - New Inbound Email Received #11950 (#11952) * [BUG] Postmark - New Inbound Email Received #11950 Sources - New Inbound Email Received * update package.json * bump version * fix prop * New Components - boloforms (#11955) * boloforms init * [Components] boloforms #11953 Sources - New Form Response (Instant) - New Template Response (Instant) - New Signature Completed (Instant) Ations - Send Form - Send Template For Signature * pnpm update * some adjusts * Tested components (#11921) * Bump actions/checkout from 4.1.5 to 4.1.6 (#12002) Bumps [actions/checkout](https://github.com/actions/checkout) from 4.1.5 to 4.1.6. - [Release notes](https://github.com/actions/checkout/releases) - [Changelog](https://github.com/actions/checkout/blob/main/CHANGELOG.md) - [Commits](actions/checkout@v4.1.5...v4.1.6) --- updated-dependencies: - dependency-name: actions/checkout dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * ServiceNow docs (#11899) * ServiceNow readme instructions * Proofreading pass * Notion readme (#11900) * Update README.md (#12006) * Update README.md (#12007) * first commit for byoa docs * more BYOA docs * arcade embed * Update oauth-clients.mdx * Update oauth-clients.mdx --------- Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Dylan J. Sather <dylan.sather@gmail.com> Co-authored-by: Luan Cazarine <luanhc@gmail.com> Co-authored-by: michelle0927 <michelle0927@users.noreply.github.com> Co-authored-by: Marcelo Jabali <mqjabali@gmail.com> Co-authored-by: michelle0927 <michellelbergero@hotmail.com> Co-authored-by: Dylan Pierce <me@dylanjpierce.com> Co-authored-by: Guilherme Falcão <48412907+GTFalcao@users.noreply.github.com> Co-authored-by: Jorge Cortes <jacortesmahmud@gmail.com> Co-authored-by: Lucas Caresia <lucascarezia@gmail.com> Co-authored-by: Leo Vu <18277920+vunguyenhung@users.noreply.github.com> Co-authored-by: Leo Vu <vunguyenhung@outlook.com> Co-authored-by: danhsiung <35384182+danhsiung@users.noreply.github.com> Co-authored-by: Michael Lim <42158621+malexanderlim@users.noreply.github.com> Co-authored-by: js07 <19861096+js07@users.noreply.github.com> Co-authored-by: Pipedream Component Development <106282845+pipedream-component-development@users.noreply.github.com> Co-authored-by: Joscha Feth <joscha@feth.com> Co-authored-by: Andrew Chuang <andrewjschuang@gmail.com> Co-authored-by: Tod Sacerdoti <todsac@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WHY
When using the dedupe strategy
uniqueand omitting theidfield in the metadata, events are not emitted correctly. They seem to be swallowed and also don't show up in the event interface.