Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support labels #67

Closed
TristanHorlamus opened this issue Dec 19, 2023 · 1 comment
Closed

support labels #67

TristanHorlamus opened this issue Dec 19, 2023 · 1 comment

Comments

@TristanHorlamus
Copy link
Contributor

Issue Description

missing ability to use label
https://docs.spring.io/spring-cloud-config/docs/current/reference/html/

Steps to Reproduce

the GetConfiguration method does not accept label as 3rd parameter and therefore won't be able to build a path to call SCC with a specific label as shown on spring cloud config documentation:
/{application}/{profile}[/{label}]

suggestion is to introduce a second function (to be backward compatible) GetConfigurationWithLabel that allows for a 3rd parameter to be used and added at the end of the path

Expected Behavior

calling GetConfiguraitonWithLabel will apply the provided label and pull the spring cloud config from the selected label (branch-name / tag)

Acceptance Criteria

Piszmog added a commit that referenced this issue Jan 24, 2024
@Piszmog
Copy link
Owner

Piszmog commented Jan 25, 2024

Closed by #68

@Piszmog Piszmog closed this as completed Jan 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants