Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add a clang format file #706

Closed
meshula opened this issue May 15, 2020 · 4 comments · Fixed by #707
Closed

add a clang format file #706

meshula opened this issue May 15, 2020 · 4 comments · Fixed by #707
Labels
good first issue If you're looking for a way to contribute, but not sure where to start. This is a good first issue.
Projects
Milestone

Comments

@meshula
Copy link
Collaborator

meshula commented May 15, 2020

A clang format file would be nice, perhaps we can use the one from OpenEXR as a starting point.

@meshula meshula added the good first issue If you're looking for a way to contribute, but not sure where to start. This is a good first issue. label May 15, 2020
@meshula meshula added this to the 1.0 Release milestone May 15, 2020
@KarthikRIyer
Copy link
Contributor

KarthikRIyer commented May 15, 2020

@meshula the OpenEXR one seems to be good. I'm currently using that to format the C-bindings.

Here's the rationalTime.h file formatted using this format. https://gist.github.com/KarthikRIyer/26a14e344b1ef740dd8c95b3382ee427

I haven't taken a close look at the file yet. Are there any specific requirements that one should take care of, for such files or is it something that just works for all people.

Personally I dont like the whitespace between the function name and the parentheses.

@meshula
Copy link
Collaborator Author

meshula commented May 15, 2020

the whitespace between the function name and the parentheses is a historical peculiarity of codebases that conform to old Silicon Graphics standards. I believe everyone is in agreement that the rule should be modified for OTIO to NOT have that space.

@meshula
Copy link
Collaborator Author

meshula commented May 15, 2020

aside from the idiosyncratic space, the file does look nice.

@ssteinbach
Copy link
Collaborator

I think this issue should include:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue If you're looking for a way to contribute, but not sure where to start. This is a good first issue.
Projects
No open projects
C++ API
  
Awaiting triage
Development

Successfully merging a pull request may close this issue.

3 participants